Closed Bug 611559 Opened 12 years ago Closed 12 years ago
Backgrounds never have PERM
_CAN _DISABLE, even when they can be disabled
Backgrounds (lightweight themes) can be disabled like any addon type now, but they never advertise that via PERM_CAN_DISABLE. So the UI never thinks a background can be disabled.
I'm not sure this blocks. Maybe I'm not understanding it though. Isn't not using a theme effectively disabling it? What's the use-case in the UI for a user disabling a theme, as distinct from just selecting a different theme?
Its for the "I don't want a background any more" use case. Currently you need to enable the theme you already have enabled (but shows as disabled because there's a background enabled). Its simpler to just disable the background that is currently enabled. The UI already has all the code and strings for this - and the API already supports disabling backgrounds (see bug 553494 comment 17 - this bug something that was overlooked there), it just doesn't advertize that to the UI.
Not going to block as the UI works ok without it. Would probably take a safe patch for it before b9 though.
blocking2.0: ? → -
A bit later than I wanted, but its tested well :)
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Attachment #513432 - Flags: review?(dtownsend)
Comment on attachment 513432 [details] [diff] [review] Patch v1 Straightforward enough I guess, bounce it at the first sign of regression though.
Whiteboard: [has patch][needs landing]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][needs landing] → [has patch]
Target Milestone: --- → mozilla2.0
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0
Status: RESOLVED → VERIFIED
Whiteboard: [has patch] → [addons-testday]
You need to log in before you can comment on or make changes to this bug.