61165 - [Classic Mac] Scrollbar thumb can be scrolled 1px less than it should be

Status: RESOLVED WONTFIX

(SeaMonkey :: Themes, defect, P4)

Description

[Matthew T (active 1999-2002)]

Build: 2000112320, Mac OS 9.0, Classic theme

To reproduce:
* Scroll any GFX scrollbar thumb all the way to the top or to the bottom of the
  scrollbar channel.

What you should see:
* A one-pixel black border between the gray of the arrow button and the blue (or
  whatever) of the button button.

What you actually see:
* A two-pixel black border between the scrollbar thumb and the arrow button --
  one pixel from the thumb, and one pixel from the button.

Don't fix this just by hiding the bottom/top border of the scrollbar button, or 
the top/bottom border of the scrollbar thumb, whenever the scrollbar thumb 
reaches the end of the channel; that would be treating the symptom rather than 
the cause, and would still leave Mozilla's scrollbar channels 2px shorter than 
native scrollbar channels of the same size. The correct fix is to include the 
bottom/top pixel of the arrow button in the area which the scrollbar thumb can 
reach.

So to look at this on its side, here's the difference between the Windows and Mac 
OS scrollbars channels (where one character is one pixel):

  up button          thumb                            down button
 ___________  ____________________                    ___________
/  ---====  \/                    \                  /  ====---  \  (Windows)
             1234567890123456789012345678901234567890
             |<---------- channel area ------------>|

  up button          thumb                             down button
,-----------.------'`'`'`'`------.                   ,-----------.
|  ---====  |                    |                   |  ====---  |  (Mac OS)
            123456789012345678901234567890123456789012
            |<----------- channel area ------------->|

CCing lordpixel, as he mentioned this problem in bug 16277.

Comment 1

[hangas]

Sending to andreww

Comment 2

[andreww]

Attachment: image with differences in skin vs os

Comment 3

[Andrew Thompson]

Attachment: See below

Comment 4

[Andrew Thompson]

And here's another very similar problem when only the vertical scrollbar is being 
drawn (yes that is Mozilla, its showing up as yellow because its running the 
scrollbar colour patch I made yesterday that's not checked in yet)

See the extra black line when there's only a vertical scrollbar?

Comment 5

[Andrew Thompson]

Doh, I clipped the thumb out of the scrollbar, but it is yellow, trust me ;)

Egg on face :)

Comment 6

[andreww]

It's the same problem. There's a black border on both elements and they simply do 
not "merge" borders when the thumb comes all the way down.  This will be an 
interesting challenge.

Comment 7

[hangas]

Themes Triage Team P4

Comment 8

[Matthew T (active 1999-2002)]

The solution for this bug would probably also allow for the missing shadow to be
added at the bottom/right of the scrollbar thumb; it could be part of the thumb
widget, and be allowed to slide under the button at the bottom/right of the
scrollbar, along with the 1px black border which comes after it.

Comment 9

[andreww]

reassigning some of my mac classic bugs so they dont fall off into 
space...

Comment 10

[Hanspeter Niederstrasser]

The Mac 8.5/9.x Mozilla port is no longer active.

Comment 11

[Simon Paquet [:sipaq]]

This bug is targeted at a Mac classic platform/OS, which is no longer supported
by mozilla.org. Please re-target it to another platform/OS if this bug applies
there as well or resolve this bug.

I will resolve this bug as WONTFIX in four weeks if no action has been taken.
To filter this and similar messages out, please filter for "mac_cla_reorg".

Comment 12

[Simon Paquet [:sipaq]]

Mac classic is obsolete now.

-> WONTFIX