611658 - The buttons found on SSL Error Page are black (dark grey)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anna (Waverley)]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101111 Firefox/4.0b8pre
Build Identifier: Mozilla /5.0 (Maemo;Linux armv7l;rv:2.0b8pre) Gecko/20101112 Firefox/4.0b8pre Fennec/4.0b3pre

The buttons found on SSL Error Page are black (dark grey).

Device: Nokia N900.

Reproducible: Always

Steps to Reproduce:
1. Visit https://overstock.com (or any secure site).
2. You should see a Error Page, complaining "Untrusted Connection". 
Actual Results:  
The buttons found on the Error Page are dark grey (sort of black).

See the attached screenshot.

Expected Results:  
The buttons found on the Error Page should be light grey.

Comment 1

[Anna (Waverley)]

Attachment: The black buttons on SSL Error page.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch adds the XUL button explicitly to the override list. This was probably broken when we added namespaces, making "button" only work for HTML buttons and not XUL.

See bug 597010 for the original fix

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/49d2be9a3e22

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED On builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101115 Namoroka/4.0b8pre Fennec/4.0b3pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101115 Namoroka/4.0b8pre Fennec/4.0b3pre