If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Default [[Image:]] to frameless and use |frame to enable old behavior

VERIFIED FIXED in 2.3

Status

support.mozilla.org
General
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: verdi, Assigned: paulc)

Tracking

unspecified

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Created attachment 490099 [details]
image with background, border and file name

When I insert an image into an article it's displayed in a box with a background color and border. Also the name of the file is listed. We should just display the image by itself without a background color, border and file name.
[[Image:title|frameless|alt text]] will do exactly that.
(Reporter)

Comment 2

7 years ago
So we have to do that each time we insert an image? Can we make that the default way an image is inserted?
Sure. Do we want to add a |frame| option or not support it at all?
(Reporter)

Comment 4

7 years ago
I don't think we'll need to have the frame or file name but can we leave the feature in? Then if for some reason we need this, you can just edit the wiki code.
To clear up one thing: it's not technically the filename, it's the title (for migrated images title=filename for compatibility) and the title is used for the default caption/alt-text.
(Reporter)

Comment 6

7 years ago
So if we don't show the title we won't have alt text?
No we'll still use the title alt text, I'm just pointing out that what shows up isn't the filename. It's the title. If you did something like:

[[Image:Nice title]]

In the frame right now, it would show "Nice title", not {some long and annoying filename}.

Comment 8

7 years ago
Definitely sounds like something we might want to start use in the future, especially a caption below the image. But for 2.3, it might be easiest to just default to no caption/title and leave the UI for the future.
So, to sum up:

* Default to no frame, no caption. (Like the current |frameless option.)
* Add a |frame option to replace it.
(Reporter)

Comment 10

7 years ago
Sounds good to me
(Assignee)

Updated

7 years ago
Assignee: nobody → paulc
(Assignee)

Updated

7 years ago
Summary: Display inserted images without the image name and border and background css → Default [[Image:]] to frameless and use |frame to enable old behavior
(Assignee)

Comment 11

7 years ago
2.3.x:
https://github.com/jsocol/kitsune/commit/591d9acfa045c8ea237ebee72edbf40c2cfaec9f
master:
https://github.com/jsocol/kitsune/commit/b358ef9b49bac64f7f65d29b523a86a74e985f57
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Verified frameless is the default, able to add frame when including image in an article
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.