611736 - Long-tap in textbox causes a click, which changes selection

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1. Select some text in a chrome textbox.
2. Long-tap on the textbox to bring up the context menu.

Expected results: Selection doesn't change.

Actual results: Depending on where you touch and how much you move your finger, the long tap may generate a click event which changes the selection or cursor location.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This patch fixes the problem by calling preventDefault on the mouseup event at the end of a long tap.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 491398 [details] [diff] [review]
patch

Wrong patch?

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch

wrong patch

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 491527 [details] [diff] [review]
patch

I'm having deja vu:

http://hg.mozilla.org/releases/mobile-1.1/file/b28b396278b1/chrome/content/InputHandler.js#l234

Comment 5

[Matt Brubeck (:mbrubeck)]

(In reply to comment #4)
> I'm having deja vu:
> 
> http://hg.mozilla.org/releases/mobile-1.1/file/b28b396278b1/chrome/content/InputHandler.js#l234

Yeah, I tried using the existing "click" suppression code, but it didn't work - we specifically need to suppress "mouseup" in this case.

Comment 6

[Benjamin Stover (:stechz)]

Comment on attachment 491527 [details] [diff] [review]
patch

Not a big fan honestly, but I can't think of anything better.

Comment 7

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/2206af2c2452

Comment 8

[Martijn Wargers (dead)]

Verified fixed, using:
Mozilla/5.0 (Maemo; Linux armv7l; rv:2.0b13pre) Gecko/20110314
Firefox/4.0b13pre Fennec/4.0b6pre

and:
Mozilla/5.0 (Android; Linux armv7l; rv:2.0b13pre) Gecko/20110314
Firefox/4.0b13pre Fennec/4.0b6pre

I've verified this, using the textbox in the Error Console.