Long-tap in textbox causes a click, which changes selection

VERIFIED FIXED

Status

defect
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

({polish})

Dependency tree / graph
Bug Flags:
in-litmus +

Firefox Tracking Flags

(fennec2.0+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Steps to reproduce:
1. Select some text in a chrome textbox.
2. Long-tap on the textbox to bring up the context menu.

Expected results: Selection doesn't change.

Actual results: Depending on where you touch and how much you move your finger, the long tap may generate a click event which changes the selection or cursor location.
tracking-fennec: --- → ?
Depends on: 585875
Assignee: nobody → mbrubeck
tracking-fennec: ? → 2.0+
Blocks: 611730
Posted patch patch (obsolete) — Splinter Review
This patch fixes the problem by calling preventDefault on the mouseup event at the end of a long tap.
Attachment #491398 - Flags: review?(mark.finkle)
Attachment #491398 - Flags: review?(ben)
Posted patch patchSplinter Review
wrong patch
Attachment #491398 - Attachment is obsolete: true
Attachment #491527 - Flags: review?(mark.finkle)
Attachment #491527 - Flags: review?(ben)
Attachment #491398 - Flags: review?(mark.finkle)
Attachment #491398 - Flags: review?(ben)
(In reply to comment #4)
> I'm having deja vu:
> 
> http://hg.mozilla.org/releases/mobile-1.1/file/b28b396278b1/chrome/content/InputHandler.js#l234

Yeah, I tried using the existing "click" suppression code, but it didn't work - we specifically need to suppress "mouseup" in this case.
Comment on attachment 491527 [details] [diff] [review]
patch

Not a big fan honestly, but I can't think of anything better.
Attachment #491527 - Flags: review?(ben) → review+
Attachment #491527 - Flags: review?(mark.finkle)
http://hg.mozilla.org/mobile-browser/rev/2206af2c2452
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified fixed, using:
Mozilla/5.0 (Maemo; Linux armv7l; rv:2.0b13pre) Gecko/20110314
Firefox/4.0b13pre Fennec/4.0b6pre

and:
Mozilla/5.0 (Android; Linux armv7l; rv:2.0b13pre) Gecko/20110314
Firefox/4.0b13pre Fennec/4.0b6pre

I've verified this, using the textbox in the Error Console.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.