611748 - On synchronous tag widget, make Return presses activate the Add button

Status: RESOLVED INVALID

(support.mozilla.org :: Knowledge Base Software, task, P5)

Description

[Erik Rose [:erik][:erikrose]]

When the tag widget does not constitute its own form, hitting Return in the tag input field should perform the same action as clicking Add. This works in Minefield right now (I stuck a display: none submit button at the top of the widget) but not in Safari 5.0.2. As a result of that hack, hitting Return in any of the other form fields hits the Add button, not whatever form-wide Submit button there may be.

Make this work more intuitively, probably by intercepting keypresses with JS.

Comment 1

[Erik Rose [:erik][:erikrose]]

For that matter, hitting Return in other form fields in Safari ignores the hidden submit control and instead hits the first tag remover X that exists. Perhaps we can't have any of those tag-related inputs be inputs in the synchronous variant of the widget. Perhaps we'll have to drive the whole thing with JS and buttons. But then that kills our JS-less fallback.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Changing the CSS for the hidden submitter does the trick for Safari:

input.hidden-submitter {
    left: -9999px;
    position: absolute;
}

Comment 3

[Erik Rose [:erik][:erikrose]]

Bless you, sir. That solves one problem.

Comment 4

[Patrick McClard;pmcclard]

Works as expected in FF29. Pressing <enter> while in the Tag text box adds the tag.