611749 - Replace non-specialized searches through array-likes in toolkit with core JS methods

Status: NEW

(Toolkit :: UI Widgets, defect)

Description

[Colby Russell :crussell (no longer Mozilla-ing)]

Menu and menulists, for example, implement getIndexOfItem as a hand-coded linear search:

http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/menu.xml#119
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/menulist.xml#279

The loops there should just be replaced by

return Array.indexOf(items);

If possible, we should perform some kind of analysis to find similar patterns.