Closed
Bug 611792
Opened 14 years ago
Closed 14 years ago
widget event listener documentation is wrong
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b1
People
(Reporter: adw, Assigned: adw)
Details
Attachments
(1 file)
|
4.58 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
The widget documentation is incorrect with regard to the arguments passed to event listeners. It says that listeners are passed only events, but they're passed the widget instance too as the first argument. I'm guessing it was not updated after the conversion to EventEmitter, which is a shame.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #490430 -
Flags: review?(dietrich)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 490430 [details] [diff] [review]
patch
r=me, thanks!
Attachment #490430 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
patch:
https://github.com/mozilla/addon-sdk/commit/fd43c15e9f775765715768c71e417b942bf89fce
merge:
https://github.com/mozilla/addon-sdk/commit/0295a0ea442e59f6ba2b7bd8f3d68263d513d656
Assignee: nobody → adw
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: -- → 0.10
|
||
Updated•13 years ago
|
Target Milestone: 0.10 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•