Closed Bug 611827 Opened 14 years ago Closed 14 years ago

#titlebar-buttonbox shouldn't be stretched to fill the title bar (can cause white border under caption buttons when using a lightweight theme)

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 4.0b8

People

(Reporter: Felipe, Assigned: dao)

References

Details

Attachments

(2 files)

Screenshot
32.07 KB, image/png
Details
patch
3.16 KB, patch
Gavin
: review+
Felipe
: feedback+
Gavin
: approval2.0+
Details | Diff | Splinter Review
Attached image Screenshot — 
As the titlebar-content is back as align mode: stretch, the widget used to display the caption buttons on the personas+glass theme is being stretched 1px taller on maximized windows. See screenshot
OS: Windows 7 → Windows XP
Attached patch patch — — Splinter Review 
Assignee: nobody → dao
Status: NEW → ASSIGNED

        Attachment #490361 -
        Flags: feedback?(felipc)

    
  
OS: Windows XP → Windows 7
Summary: The titlebar stretches 1px too tall on maximized windows, displaying white border on caption buttons → #titlebar-buttonbox shouldn't be stretched to fill the title bar (can cause white border under caption buttons when using a lightweight theme)
Version: unspecified → Trunk

    
  

        Attachment #490361 -
        Flags: review?(gavin.sharp)

    
  
Blocks: 572160

    
    

    
  
Comment on attachment 490361 [details] [diff] [review]
patch

Thanks Dao. Yeah I think this is the best solution to avoid stretching the buttons in the future, as some themes size the titlebar-buttonbox and others size the buttons themselves.

        Attachment #490361 -
        Flags: feedback?(felipc) → feedback+

    
  
No longer blocks: 572160

        Attachment #490361 -
        Flags: review?(gavin.sharp)

        Attachment #490361 -
        Flags: review+

        Attachment #490361 -
        Flags: approval2.0+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/4c960203c759
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: