Closed
Bug 611869
Opened 15 years ago
Closed 15 years ago
display_name is not set in remora User session object
Categories
(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)
addons.mozilla.org Graveyard
Admin/Editor Tools
Tracking
(Not tracked)
RESOLVED
FIXED
5.12.3
People
(Reporter: jorgev, Unassigned)
Details
(Whiteboard: [ReviewTeam])
Attachments
(1 file)
|
1.34 KB,
patch
|
clouserw
:
review+
|
Details | Diff | Splinter Review |
It looks like my patch for bug 607084 isn't complete, and there are cases where the review emails are still being sent with an empty sender name.
When setting up the email subject, I use $session['display_name']. Looking around I found the User object, which is apparently out of date and uses the nickname or first name and last name to create the display_name field in the session. I think that's the cause of this problem, do I attempt to address that with this patch.
I know it's a stretch with code freeze in a couple of hours. Feel free to move it to .4 if it can't be pushed today.
Attachment #490261 -
Flags: review?(clouserw)
|
Reporter | |
Updated•15 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 1•15 years ago
|
||
Comment on attachment 490261 [details] [diff] [review]
Patch V1. Set real display name on User object
thanks
Attachment #490261 -
Flags: review?(clouserw) → review+
|
|
Reporter | |
Comment 2•15 years ago
|
||
Yay!
Fixed in r77460.
*ducks*
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 3•13 years ago
|
||
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
|
Assignee | |
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•