611934 - [OS/2] Follow up to bug# 598862

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Dave Yeo]

After checkin 57136:ed1d65957bd0 the build now breaks as so,

In file included from I:/comm-central.bak/mozilla/xpcom/glue/FileUtils.cpp:49:
../../dist/include/mozilla/FileUtils.h: In destructor 'mozilla::ScopedClose::~ScopedClose()':
../../dist/include/mozilla/FileUtils.h:82: error: 'close' was not declared in this scope
make.exe[6]: *** [FileUtils.o] Error 1

Fix is to include io.h or unistd.h

Comment 1

[Dave Yeo]

Attachment: include io.h for close()

Simple fix, asking Chris for review as it was his patch.

Comment 2

[Rich Walsh]

Attachment: implement fallocate() and fix build break

Comment 3

[Dave Yeo]

+#elif defined(XP_OS2)
+  return DosSetFileSizeL(PR_FileDesc2NativeHandle(aFD), aLength) == 0;

Should we be using the large file API here? I've lost track but aren't we still supporting OS/2 versions older then 4.5?

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 490412 [details] [diff] [review]
implement fallocate() and fix build break

I can r+ the build-bustage patch but not the fallocate() implementation.  You'll need to separate the two and ask for review from :taras on the fallocate impl (or ask taras to r+ this patch, whichever).

Comment 5

[Rich Walsh]

Attachment: implement fallocate() and fix build break - v2

This implements fallocate() on OS/2 and fixes a build break caused by a missing header.  Per Comment #3, this version is compatible with earlier versions of OS/2.

Comment 6

[Rich Walsh]

Attachment: implement fallocate() and fix build break - v2a

bitrot update - carrying over r+ from tglek

Comment 7

[Walter Meinl]

Comment on attachment 500476 [details] [diff] [review]
implement fallocate() and fix build break - v2a

practically zero risk for tier1, though in cross-platform files all is ifdef'd for XP_OS2 - NPOTB

Comment 8

[Rich Walsh]

Attachment: implement fallocate() and fix build break - v2b

fixes a typo - carrying over r+ from tglek - see comment 7

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/a548a19f34a2