After checkin 57136:ed1d65957bd0 the build now breaks as so, In file included from I:/comm-central.bak/mozilla/xpcom/glue/FileUtils.cpp:49: ../../dist/include/mozilla/FileUtils.h: In destructor 'mozilla::ScopedClose::~ScopedClose()': ../../dist/include/mozilla/FileUtils.h:82: error: 'close' was not declared in this scope make.exe: *** [FileUtils.o] Error 1 Fix is to include io.h or unistd.h
Simple fix, asking Chris for review as it was his patch.
+#elif defined(XP_OS2) + return DosSetFileSizeL(PR_FileDesc2NativeHandle(aFD), aLength) == 0; Should we be using the large file API here? I've lost track but aren't we still supporting OS/2 versions older then 4.5?
Comment on attachment 490412 [details] [diff] [review] implement fallocate() and fix build break I can r+ the build-bustage patch but not the fallocate() implementation. You'll need to separate the two and ask for review from :taras on the fallocate impl (or ask taras to r+ this patch, whichever).
This implements fallocate() on OS/2 and fixes a build break caused by a missing header. Per Comment #3, this version is compatible with earlier versions of OS/2.
bitrot update - carrying over r+ from tglek
Component: Graphics → General
QA Contact: thebes → general
Comment on attachment 500476 [details] [diff] [review] implement fallocate() and fix build break - v2a practically zero risk for tier1, though in cross-platform files all is ifdef'd for XP_OS2 - NPOTB
fixes a typo - carrying over r+ from tglek - see comment 7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
You need to log in before you can comment on or make changes to this bug.