Closed
Bug 611960
Opened 14 years ago
Closed 14 years ago
bustage on Win64 after bug 583138 is landed
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(2 files)
567 bytes,
patch
|
roc
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
842 bytes,
patch
|
Details | Diff | Splinter Review |
We should use _M_IX86 macro with MOZILLA_COMPILE_WITH_SSE2 because x64 compiler has no inline assembler.
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #490347 -
Flags: review+
Attachment #490347 -
Flags: approval2.0+
I guess this means the assembly code should be ported to YASM so it can be used on Win64...
Comment 3•14 years ago
|
||
Or use intrinsics. See bug 571139 which has an implementation of the older YCbCr conversion code.
Comment 4•14 years ago
|
||
Note that this fix needs a patch file containing the change and an update to update.sh and the README describing the change.
Comment 5•14 years ago
|
||
I also think the better define to use rather than _M_IX86 is ARCH_CPU_X86_32 (defined in chromium_types.h).
Assignee | ||
Comment 6•14 years ago
|
||
(In reply to comment #3) > Or use intrinsics. See bug 571139 which has an implementation of the older > YCbCr conversion code. I will update to intrinsic version by Bug 571739. I was waiting that bug 577843 and 583138 were fixed.
Assignee | ||
Comment 7•14 years ago
|
||
(In reply to comment #5) > I also think the better define to use rather than _M_IX86 is ARCH_CPU_X86_32 > (defined in chromium_types.h). Other place (yuv_convert.cpp) uses _M_IX86 and inline code is Microsoft specific code, so ARCH_CPU_X86_32 isn't best even if Makefile defines MSC_VER only.
Assignee | ||
Comment 8•14 years ago
|
||
Assignee | ||
Comment 9•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b8a0c34bb9f7
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Comment 10•14 years ago
|
||
You forgot the update to README and update.sh.
Comment 11•14 years ago
|
||
Oh I see you edited the convert.patch directly rather than adding a separate patch. Disregard comment 10.
You need to log in
before you can comment on or make changes to this bug.
Description
•