612071 - crash [@ nsBayesianFilter::classifyMessage(Tokenizer&, char const*, nsTArray<unsigned int>&, nsTArray<unsigned int>&, nsIJunkMailClassificationListener*, nsIMsgTraitClassificationListener*, nsIMsgTraitDetailListener*)]

Status: RESOLVED INCOMPLETE

(MailNews Core :: Filters, defect)

Description

[Wayne Mery (:wsmwk)]

crash [@ nsBayesianFilter::classifyMessage(Tokenizer&, char const*, nsTArray<unsigned int>&, nsTArray<unsigned int>&, nsIJunkMailClassificationListener*, nsIMsgTraitClassificationListener*, nsIMsgTraitDetailListener*)]

pretty rare crash.  v3.1.6 line number not same as v3.1.4

v3.1.6 bp-374254f6-8c1c-41b8-8cff-1184e2101103
0	thunderbird.exe	nsBayesianFilter::classifyMessage	mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:1554
1	thunderbird.exe	MessageClassifier::analyzeTokens	mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:1367
2	thunderbird.exe	TokenStreamListener::OnStopRequest	mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:1208
3	thunderbird.exe	nsStreamConverter::OnStopRequest	mailnews/mime/src/nsStreamConverter.cpp:1116 

v3.1.4 bp-df922196-9b4c-4ec1-8d71-cf70a2101020
0 	thunderbird.exe 	nsBayesianFilter::classifyMessage 	mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:1714
1 	thunderbird.exe 	MessageClassifier::analyzeTokens 	mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:1367
2 	thunderbird.exe 	TokenStreamListener::OnStopRequest 	mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:1208
3 	thunderbird.exe 	nsStreamConverter::OnStopRequest 	mailnews/mime/src/nsStreamConverter.cpp:1116
4 	thunderbird.exe 	nsMsgProtocol::OnStopRequest 	mailnews/base/util/nsMsgProtocol.cpp:401
5 	thunderbird.exe 	nsMailboxProtocol::OnStopRequest 	mailnews/local/src/nsMailboxProtocol.cpp:381
6 	thunderbird.exe 	nsInputStreamPump::OnStateStop 	netwerk/base/src/nsInputStreamPump.cpp:578

Comment 1

[Wayne Mery (:wsmwk)]

yet another line number at the top ...
but frame 1 is the same in all 3 crashes stated so far

bp-3b6d19c8-7115-42e9-adb7-9bbbc2101007 v3.1.4 Mac
0	thunderbird-bin	nsBayesianFilter::classifyMessage	mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:2718
1	thunderbird-bin	MessageClassifier::analyzeTokens	mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:1367
2	thunderbird-bin	TokenStreamListener::OnStopRequest	mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:1208
3	thunderbird-bin	nsStreamConverter::OnStopRequest	mailnews/mime/src/nsStreamConverter.cpp:1116
4	thunderbird-bin	nsStreamListenerTee::OnStopRequest	netwerk/base/src/nsStreamListenerTee.cpp:72

Comment 2

[Kent James (:rkent)]

The "analyzeTokens" from frame 1 is just the entry into the complex bayesian filter code. I suspect each of these crashes are independent. Looking at them, there is no obvious way they could happen, nor any obvious fix either.

Comment 3

[Wayne Mery (:wsmwk)]

in 5 months one example in v3.1.16 bp-cbcf1843-9961-48a7-9aad-ed2492111129

but no examples with same signature in version 5 or newer. However, the stack appears for signature nsBayesianFilter::classifyMessage(Tokenizer&, char const*, nsTArray<unsigned int, nsTArrayDefaultAllocator>&, nsTArray<unsigned int, nsTArrayDefaultAllocator>&, nsIJunkMailClassificationListener*, nsIMsgTraitClassificationListener*, nsIMsgTraitDetailLi...

Comment 4

[Wayne Mery (:wsmwk)]

as in bp-aa481123-ca21-4a33-a22c-3634e2111202 (version 8)

Comment 5

[Wayne Mery (:wsmwk)]

(In reply to Kent James (:rkent) from comment #2)
> The "analyzeTokens" from frame 1 is just the entry into the complex bayesian
> filter code. I suspect each of these crashes are independent. Looking at
> them, there is no obvious way they could happen, nor any obvious fix either.

On that basis I'm going to close this incomplete.

Less than a dozen crashes in the past month, all pointing to the same code cited in comment 0 and 1

bp-6c2bd794-ad0f-4a52-9296-c3abe2151104 @  nsBayesianFilter::classifyMessage 
http://hg.mozilla.org/comm-central/annotate/tip/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp#l1583

bp-9d8600e4-9cf6-408b-92df-217992151005 all Mac crashes
@ nsBayesianFilter::classifyMessage(Tokenizer&, char const*, nsTArray<T>&, nsTArray<T>&, nsIJunkMailClassificationListener*, nsIMsgTraitClassificationListener*, nsIMsgTraitDetailListener*)
http://hg.mozilla.org/comm-central/annotate/tip/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp#l2658