Closed Bug 612164 Opened 9 years ago Closed 9 years ago

DATA_CLONE_ERR has the wrong constant

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b8
Tracking Status
blocking2.0 --- beta8+

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

()

Details

Attachments

(1 file, 1 obsolete file)

DATA_CLONE_ERR has code 25 assigned to it, but we use 18, which is SECURITY_ERR.
Attached patch Patch v1 (obsolete) — Splinter Review
Assignee: nobody → Ms2ger
Attachment #491884 - Flags: review?(jst)
blocking2.0: --- → ?
Not blocking on this, and at this point I think I'd rather not change this any more for Firefox 4. This has been broken forever hasn't it? If so, the risk of taking this change now is higher than the gain IMO.
blocking2.0: ? → -
This constant was added after b6, so, yes, you could say it's been wrong forever.
Comment on attachment 491884 [details] [diff] [review]
Patch v1

Oh, sorry, I thought this one had been shipped in 3.6 etc, but that's clearly not the case. In that case, I think we should fix this while we still can do so w/o running a risk of breaking a bunch of sites etc.
Attachment #491884 - Flags: review?(jst) → review+
Let's get this in for beta8 if at all possible then, to minimize exposing this incorrect value to the world...
blocking2.0: - → beta8+
No problem, I gathered. Thanks for the review.
Attachment #491884 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/114966e5b168
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.