612164 - DATA_CLONE_ERR has the wrong constant

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

DATA_CLONE_ERR has code 25 assigned to it, but we use 18, which is SECURITY_ERR.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 2

[Johnny Stenback (:jst)]

Not blocking on this, and at this point I think I'd rather not change this any more for Firefox 4. This has been broken forever hasn't it? If so, the risk of taking this change now is higher than the gain IMO.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

This constant was added after b6, so, yes, you could say it's been wrong forever.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 491884 [details] [diff] [review]
Patch v1

Oh, sorry, I thought this one had been shipped in 3.6 etc, but that's clearly not the case. In that case, I think we should fix this while we still can do so w/o running a risk of breaking a bunch of sites etc.

Comment 5

[Johnny Stenback (:jst)]

Let's get this in for beta8 if at all possible then, to minimize exposing this incorrect value to the world...

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch for checkin

No problem, I gathered. Thanks for the review.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/114966e5b168