612181 - Clicking edge of popup notification button main action button opens the dropdown instead

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Jesse Ruderman]

When Firefox shows a doorhanger asking if I want it to remember my password, the bottom pixel or two of the "Remember password" button misbehaves when clicked.

Comment 1

[:Margaret Leibovic]

I was also able to reproduce this on Windows. It seems like clicking on the border of the button (on any side, not just the bottom) opens the menupopup, even if you are on the left side of the button.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

This is a problem with menu-buttons in general.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Hmm, or it was in the past, anyways. It's possible the popup-notification styling in particular is making the problem worse (or exposing a problem that has since been fixed in the base binding).

Comment 4

[Dão Gottwald [:dao]]

I don't know about Mac, but for Windows it seems that the outer button just shouldn't have a border. Instead, all borders should be part of either the inner button or the dropmarker.

Comment 5

[:Margaret Leibovic]

Attachment: patch (winstripe)

Yes, setting the border on the inner elements fixed it on windows. (I had to set the !important flag for .button-menubutton-dropmarker to pick up the style.)

The pinstripe styles are already setting the border on the inner elements, so that's going to require a different fix.

Comment 6

[Dão Gottwald [:dao]]

(In reply to comment #5)
> (I had to
> set the !important flag for .button-menubutton-dropmarker to pick up the
> style.)

Sigh... can you remove the !important flags in button.css?

Comment 7

[:Margaret Leibovic]

Attachment: patch v2 (winstripe)

Removed !important flag from style in button.css.

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 491004 [details] [diff] [review]
patch v2 (winstripe)

>diff --git a/toolkit/themes/winstripe/global/button.css b/toolkit/themes/winstripe/global/button.css
>--- a/toolkit/themes/winstripe/global/button.css
>+++ b/toolkit/themes/winstripe/global/button.css
>@@ -150,17 +150,17 @@ button[type="menu-button"] {
>   border: none;
> }
> 
> .button-menu-dropmarker,
> .button-menubutton-dropmarker {
>   -moz-appearance: none !important;
>   margin: 1px;
>   background-color: transparent !important;
>-  border: none !important;
>+  border: none;
>   width: 11px;
>   height: 11px;
> }

Please remove if from background-color as well.

Comment 9

[:Margaret Leibovic]

Comment on attachment 491004 [details] [diff] [review]
patch v2 (winstripe)

I'm having a hard time figuring out how to fix this for OSX, but we should land this patch to at least fix the problem on Windows.

Comment 10

[LegNeato]

Comment on attachment 491004 [details] [diff] [review]
patch v2 (winstripe)

Approved for 2.0

Comment 11

[:Margaret Leibovic]

Pushed winstripe fix: http://hg.mozilla.org/mozilla-central/rev/52eebb84e381.

I'll keep the bug open to try to make a pinstripe fix.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Pinstripe fix coming? Should we file a follow-up, instead?

Comment 13

[:Margaret Leibovic]

Filed bug 638582 as a follow-up for pinstripe.