Closed Bug 612181 Opened 9 years ago Closed 9 years ago

Clicking edge of popup notification button main action button opens the dropdown instead

Categories

(Toolkit :: Themes, defect)

All
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: Margaret)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

When Firefox shows a doorhanger asking if I want it to remember my password, the bottom pixel or two of the "Remember password" button misbehaves when clicked.
I was also able to reproduce this on Windows. It seems like clicking on the border of the button (on any side, not just the bottom) opens the menupopup, even if you are on the left side of the button.
OS: Mac OS X → All
Hardware: x86 → All
Summary: Clicking bottom edge of "Remember password" button opens the dropdown instead → Clicking edge of popup notification button main action button opens the dropdown instead
This is a problem with menu-buttons in general.
Component: General → XUL Widgets
Product: Firefox → Toolkit
QA Contact: general → xul.widgets
Hmm, or it was in the past, anyways. It's possible the popup-notification styling in particular is making the problem worse (or exposing a problem that has since been fixed in the base binding).
I don't know about Mac, but for Windows it seems that the outer button just shouldn't have a border. Instead, all borders should be part of either the inner button or the dropmarker.
Attached patch patch (winstripe) (obsolete) — Splinter Review
Yes, setting the border on the inner elements fixed it on windows. (I had to set the !important flag for .button-menubutton-dropmarker to pick up the style.)

The pinstripe styles are already setting the border on the inner elements, so that's going to require a different fix.
Assignee: nobody → margaret.leibovic
Attachment #490999 - Flags: review?(dao)
(In reply to comment #5)
> (I had to
> set the !important flag for .button-menubutton-dropmarker to pick up the
> style.)

Sigh... can you remove the !important flags in button.css?
Removed !important flag from style in button.css.
Attachment #490999 - Attachment is obsolete: true
Attachment #491004 - Flags: review?(dao)
Attachment #490999 - Flags: review?(dao)
Comment on attachment 491004 [details] [diff] [review]
patch v2 (winstripe)

>diff --git a/toolkit/themes/winstripe/global/button.css b/toolkit/themes/winstripe/global/button.css
>--- a/toolkit/themes/winstripe/global/button.css
>+++ b/toolkit/themes/winstripe/global/button.css
>@@ -150,17 +150,17 @@ button[type="menu-button"] {
>   border: none;
> }
> 
> .button-menu-dropmarker,
> .button-menubutton-dropmarker {
>   -moz-appearance: none !important;
>   margin: 1px;
>   background-color: transparent !important;
>-  border: none !important;
>+  border: none;
>   width: 11px;
>   height: 11px;
> }

Please remove if from background-color as well.
Attachment #491004 - Flags: review?(dao) → review+
Comment on attachment 491004 [details] [diff] [review]
patch v2 (winstripe)

I'm having a hard time figuring out how to fix this for OSX, but we should land this patch to at least fix the problem on Windows.
Attachment #491004 - Flags: approval2.0?
Comment on attachment 491004 [details] [diff] [review]
patch v2 (winstripe)

Approved for 2.0
Attachment #491004 - Flags: approval2.0? → approval2.0+
Pushed winstripe fix: http://hg.mozilla.org/mozilla-central/rev/52eebb84e381.

I'll keep the bug open to try to make a pinstripe fix.
Pinstripe fix coming? Should we file a follow-up, instead?
Whiteboard: [approved-patches-landed]
Blocks: 638582
Filed bug 638582 as a follow-up for pinstripe.
Status: NEW → RESOLVED
Closed: 9 years ago
Component: XUL Widgets → Themes
OS: All → Windows 7
QA Contact: xul.widgets → themes
Resolution: --- → FIXED
Whiteboard: [approved-patches-landed]
You need to log in before you can comment on or make changes to this bug.