Closed
Bug 612258
Opened 14 years ago
Closed 14 years ago
xulrunner compilation failure after landing bug 603679
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
nsSetDllDirectory.h can't be found both when compiling xulrunner/app and xulrunner/stub. For xulrunner/app, adding xpcom/base to LOCAL_INCLUDES fixes the problem. It doesn't work xulrunner/stub as it doesn't link to xpcom (so NS_SetDllDirectory can't be found), so XRE_DONT_PROTECT_DLL_LOAD seems more appropriate. It also requires a change to nsWindowsWMain.cpp that protects NS_SetDllDirectory call by XRE_DONT_PROTECT_DLL_LOAD, but not includeing nsSetDllDirectory.h.
|
Assignee | |
Updated•14 years ago
|
Attachment #490552 -
Attachment is patch: true
Attachment #490552 -
Flags: review?(khuey)
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → jacek
Severity: normal → major
OS: Linux → Windows XP
Hardware: x86_64 → x86
|
|
Assignee | |
Comment 1•14 years ago
|
||
I forgot to mention, that I've tested it on mingw, but it affects all Windows builds.
No longer blocks: 603679
blocking2.0: --- → ?
Comment on attachment 490552 [details] [diff] [review]
fix v1.0
I did half of this by adding xpcom/base to the include path for app and stub, so that part will be bitrotted, but XRE_DONT_PROTECT_DLL_LOAD sounds good.
r=me
Attachment #490552 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Thanks for quick review! Pushed as NPOTB (like your previous push):
http://hg.mozilla.org/mozilla-central/rev/4b11b59eefe2
Status: NEW → RESOLVED
blocking2.0: ? → ---
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla2.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•