Closed Bug 612338 Opened 13 years ago Closed 13 years ago

Package ConsoleAPI.js

Categories

(Thunderbird :: Installer, defect)

Product:
Thunderbird
Component:
Installer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.3a2

People

(Reporter: Gavin, Assigned: philor)

References

Details

Attachments

(1 file, 1 obsolete file)

Fix v.2
1.55 KB, patch
standard8
: review+
Details | Diff | Splinter Review
Blocks: lazy-console
No longer depends on: 612337
Attached patch Fix (obsolete) — — Splinter Review 
Along with necko_wyciwyg from bug 561085, startupcache from bug 520309, and webapps from bug 590225 (which lacks any actual explanation of _why_ everyone should build it, but it's pretty cheap).
Attachment #490671 - Flags: review?(bugzilla)
Assignee: nobody → philringnalda
Comment on attachment 490671 [details] [diff] [review]
Fix

I'm not convinced we should be packaging statupcache.xpt, according to the code at the moment it is test-only:

http://mxr.mozilla.org/comm-central/source/mozilla/startupcache/nsIStartupCache.idl#49

afaict FF doesn't package it either
Attached patch Fix v.2 — — Splinter Review 
Oh, yeah, at one point I knew that, along with knowing that the pointless building of webapps.xpt didn't extend to pointlessly packaging it for Firefox.
Attachment #490671 - Attachment is obsolete: true
Attachment #490711 - Flags: review?(bugzilla)
Attachment #490671 - Flags: review?(bugzilla)
Attachment #490711 - Flags: review?(bugzilla) → review+
No longer blocks: lazy-console
Depends on: lazy-console
http://hg.mozilla.org/comm-central/rev/09778c4043bc
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a2
You need to log in before you can comment on or make changes to this bug.