"Could not get engine: clients" in Sync log

RESOLVED FIXED

Status

Cloud Services
Firefox Sync: Backend
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Long-standing little bug. Clients is a special engine; updateEnabledEngines needs to know about it and not complain on failure.

(Alternatively, EngineManagerSvc needs to know about it and return it when asked.)
(Assignee)

Comment 1

8 years ago
Created attachment 515806 [details] [diff] [review]
Proposed patch. v1
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Attachment #515806 - Flags: review?(philipp)
Attachment #515806 - Flags: review?(philipp) → review+
Comment on attachment 515806 [details] [diff] [review]
Proposed patch. v1

Yay for removing spurious logging.
Attachment #515806 - Flags: approval2.0+
(Assignee)

Comment 3

8 years ago
Pushed to fx-sync:

http://hg.mozilla.org/services/fx-sync/rev/543d4b41daf1
Whiteboard: [fixed in fx-sync]
Whiteboard: [fixed in fx-sync] → [fixed in fx-sync][fixed in services]
Merged to m-c: http://hg.mozilla.org/mozilla-central/rev/1a0094bc7086
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-sync][fixed in services]
Engine.Clients appears to be fine with beta12 on stage
Status: RESOLVED → VERIFIED
(In reply to comment #6)
> Engine.Clients appears to be fine with beta12 on stage

This only landed in mozilla-central today, not in beta12. It also doesn't fix a bug with the clients engine, it just gets rid of an annoying, misleading and unnecessary log message.
Status: VERIFIED → RESOLVED
Last Resolved: 8 years ago8 years ago
You need to log in before you can comment on or make changes to this bug.