XrayWrapper.cpp:239:21: warning: converting to non-pointer type ‘uintN’ from NULL

RESOLVED FIXED in mozilla2.0b8

Status

()

Core
XPConnect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla2.0b8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

> js/src/xpconnect/wrappers/XrayWrapper.cpp: In function ‘bool xpc::ResolveNativeProperty(JSContext*, JSObject*, JSObject*, jsid, bool, JSPropertyDescriptor*)’:
> js/src/xpconnect/wrappers/XrayWrapper.cpp:239:21: warning: converting to non-pointer type ‘uintN’ from NULL

Code:
> 237     desc->getter = NULL;
> 238     desc->setter = NULL;
> 239     desc->shortid = NULL;
> 240     desc->value = JSVAL_VOID;

The "shortid" member var is a uintN (unsigned integer), so it should be set to 0 rather than null.
Created attachment 490717 [details] [diff] [review]
trivial fix
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #490717 - Flags: review?(gal)
OS: Linux → All
Hardware: x86_64 → All

Updated

8 years ago
Attachment #490717 - Flags: review?(gal) → review+
Comment on attachment 490717 [details] [diff] [review]
trivial fix

Requesting landing approval. Trivial fix w/ no functional impact -- just a s/NULL/0/ to fix a build warning.
Attachment #490717 - Flags: approval2.0?
Attachment #490717 - Flags: approval2.0? → approval2.0+
Landed: http://hg.mozilla.org/mozilla-central/rev/6d7b682a3cc4
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.