612461 - Should not be able to cd into files

Status: RESOLVED DUPLICATE of bug 650110

(Testing :: General, defect)

Description

[Mark Côté [:mcote]]

It seems that it is possible to cd into a file on the Android agent:

$>cd /data/data/org.mozilla.fennec/mozilla/r9scam8i.default/.parentlock
$>cwd
/data/data/org.mozilla.fennec/mozilla/r9scam8i.default/.parentlock
$>ls
##AGENT-WARNING## /data/data/org.mozilla.fennec/mozilla/r9scam8i.default/.parentlock is not a directory

This breaks various parts of the devicemanager, which uses cd to determine what are directories and what are plain files.

Comment 1

[Mark Côté [:mcote]]

Attachment: isdir command and various small fixes

Bob implemented the "isdir" command on the Android agent.  This is a patch to devicemanager to expose it and to use it in getDirectory().

Other bonus fixes:
- catFile() function
- in listFiles(), strip trailing slashes from paths, since it confuses the Android agent, and filter empty paths from results

Comment 2

[cmtalbert]

Comment on attachment 491894 [details] [diff] [review]
isdir command and various small fixes

This looks good.  Thanks.  We need to check this in.  I think we should run this in staging first with Joel's changes for Talos and then checkin both the talos changes and this in one landing.

Comment 3

[cmtalbert]

Attachment: Agent with commands to support the new functionality

This is a new sutagent version that allows for callbacks during the update process and implements the isdir command.

Comment 4

[cmtalbert]

This has been fixed in bug 650110, marking as dupe.