Closed Bug 612613 Opened 10 years ago Closed 10 years ago

Comments only: Clarify intention of nsIX509CertDB::findEmail[Encryption|Signing]Cert

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: KaiE, Assigned: KaiE)

Details

Attachments

(1 file)

Patch v1
947 bytes, patch
mayhemer
: review+
Details | Diff | Splinter Review 
As Kaspar correctly clarifies in bug 337430 comment 6,
the intention and current implementation of 
  nsIX509CertDB::findEmailSigningCert 
and
  nsIX509CertDB::findEmailEncryptionCert 
is to return a "user certificate", i.e. a cert where a private key is available.

I agree with Kaspar that things could go wrong if we changed that behaviour.
We should update the comments to make that clear.
Attached patch Patch v1 — — Splinter Review
Assignee: nobody → kaie
Attachment #490908 - Flags: review?(honzab.moz)
Comment on attachment 490908 [details] [diff] [review]
Patch v1

r=honzab
Attachment #490908 - Flags: review?(honzab.moz) → review+
Attachment #490908 - Flags: approval2.0?
Attachment #490908 - Flags: approval2.0?
pushed with 
  a=comment-only

http://hg.mozilla.org/mozilla-central/rev/4ca0f5411f13
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.