The default bug view has changed. See this FAQ.

intermittent orange: test_bug607584.xul continues executing after we've left the page, mostly showing up in test_bug171813.html

RESOLVED FIXED in mozilla2.0b8

Status

()

Core
Editor
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: dbaron, Assigned: Ehsan)

Tracking

({intermittent-failure})

Trunk
mozilla2.0b8
intermittent-failure
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
There have been a number of JS errors happening during the execution of other test in which we're trying to execute code from test_bug607584.xul.  These have been previously reported (search for test_bug607584.xul) in bug 591726, bug 611238, bug 612448, and bug 612484.

The error on tinderbox (causing orange) looks like this (with variation in which test it's happening in):

7089 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/extensions/universalchardet/tests/test_bug171813.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - Components is not defined at chrome://mochitests/content/chrome/editor/libeditor/html/tests/test_bug607584.xul:57
7090 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/extensions/universalchardet/tests/test_bug171813.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - Components is not defined at chrome://mochitests/content/chrome/editor/libeditor/html/tests/test_bug607584.xul:57
(Reporter)

Updated

6 years ago
Summary: test_bug607584.xul continues executing after we've left the page → intermittent orange: test_bug607584.xul continues executing after we've left the page
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1289916569.1289917592.13029.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central opt test mochitest-other on 2010/11/16 06:09:29 
s: talos-r3-leopard-033

6354 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/extensions/universalchardet/tests/test_bug171813.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - Components is not defined at chrome://mochitests/content/chrome/editor/libeditor/html/tests/test_bug607584.xul:57
6355 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/extensions/universalchardet/tests/test_bug171813.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - Components is not defined at chrome://mochitests/content/chrome/editor/libeditor/html/tests/test_bug607584.xul:57
Summary: intermittent orange: test_bug607584.xul continues executing after we've left the page → intermittent orange: test_bug607584.xul continues executing after we've left the page, mostly showing up in test_bug171813.html
I recommend getting rid of this test. test_bug607584.html is largely enough for the patch.
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 9

6 years ago
Created attachment 490977 [details] [diff] [review]
Patch (v1)

We should remove the progress listener when we're done.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #490977 - Flags: review?(roc)
     var progress = docShell.QueryInterface(Components.interfaces.nsIInterfaceRequestor).getInterface(Components.interfaces.nsIWebProgress);
-    var progressListener = new EditorContentListener(newEditorElement);
+    progressListener = new EditorContentListener(newEditorElement);

Shouldn't you have removed 'var' from 'progress' instead of 'progressListener'?
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 35

6 years ago
Created attachment 491114 [details] [diff] [review]
Patch (v1)

(In reply to comment #10)
>      var progress =
> docShell.QueryInterface(Components.interfaces.nsIInterfaceRequestor).getInterface(Components.interfaces.nsIWebProgress);
> -    var progressListener = new EditorContentListener(newEditorElement);
> +    progressListener = new EditorContentListener(newEditorElement);
> 
> Shouldn't you have removed 'var' from 'progress' instead of 'progressListener'?

Yes.  Specifically, I should have qrefreshed the correct patch!
Attachment #490977 - Attachment is obsolete: true
Attachment #491114 - Flags: review?(roc)
Attachment #490977 - Flags: review?(roc)
Attachment #491114 - Flags: review?(roc) → review+
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 51

6 years ago
http://hg.mozilla.org/mozilla-central/rev/b433764562cc
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Keywords: intermittent-failure
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.