Closed
Bug 612664
Opened 14 years ago
Closed 14 years ago
make Panel.show() docs specify that it takes a handle argument
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b1
People
(Reporter: myk, Assigned: adw)
References
Details
Attachments
(1 file)
|
763 bytes,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
Panel.show() takes a DOMElement argument, but it isn't possible to pass DOM objects across process boundaries. Instead, the method should take a handle <https://developer.mozilla.org/en/Jetpack_Processes#Handles> that APIs like Widget and Page Mods can obtain from the chrome process. For the first beta release, we need to fix the docs to specify that the type of the argument passed to Panel.show() is a handle. Actually passing a handle rather than a DOMElement will happen when we update the API implementations to work across processes.
|
Reporter | |
Comment 2•14 years ago
|
||
Comment on attachment 492008 [details] [diff] [review] patch Great!
Attachment #492008 -
Flags: review?(myk) → review+
|
Assignee | |
Comment 3•14 years ago
|
||
https://github.com/mozilla/addon-sdk/commit/a8afa08bd817f05efaa9de105d0f2ebcd16b8e99
Assignee: nobody → adw
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•