612677 - TEST_PATH has stopped working for 'make crashtest'

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

From bug 610290 comment 4:

I used to be able to do:

make -C objdir crashtest TEST_PATH=path/to/crashtest.list

Now, neither of these two work, and they both result in the entire crashtest
suite to be run:

make -C objdir crashtest TEST_PATH=path/to/crashtest.list
TEST_PATH=path/to/crashtest.list make -C objdir crashtest

Comment 1

[(not currently active) Ted Mielczarek]

I don't know how that would have affected crashtest. Try backing the patch out locally?

Comment 2

[Mounir Lamouri (:mounir)]

I've reverted the patch locally and it seems that it is fixing the issue but I really don't understand how that could happen :/
Weirdly, changing TEST_PATH=foo to TEST_PATH?=foo in crashtest and jstestbrowser fixes the issue...

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 4

[Mounir Lamouri (:mounir)]

CCing Kyle in case of he wants to steal the review ;)

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 491035 [details] [diff] [review]
Patch v1

r=me

FWIW, I'd call this NPOTB and check it in.

Comment 6

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/1b4d00d79ae6

Unfortunately, I still don't understand why it wasn't working (doesn't make sense to me) but if this patch fix it, that's nice :)