Closed
Bug 612719
Opened 14 years ago
Closed 14 years ago
remove "ready" event from Page Worker API doc
Categories
(Add-on SDK Graveyard :: Documentation, defect)
Add-on SDK Graveyard
Documentation
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b1
People
(Reporter: myk, Assigned: adw)
References
Details
Attachments
(1 file)
|
658 bytes,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
The Page Worker API's "ready" event is no longer useful now that the API does not give addons direct access to the DOM of loaded pages. Addons should instead use content scripts to handle DOM readiness, and we should remove the "ready" event.
|
Assignee | |
Comment 1•14 years ago
|
||
I'm having trouble following the spaghetti of traits and dependencies, but it looks like page-worker doesn't actually have a ready event. The hidden-frame constructor takes an onReady option, and symbiont uses it to init its frame, and Page in page-worker is composed of Symbiont, but onReady or a ready event doesn't appear to be part of page-worker's or symbiont's or worker's API. So this patch only removes the ready event from page-worker's doc.
Attachment #492019 -
Flags: review?(myk)
|
Reporter | |
Comment 2•14 years ago
|
||
Comment on attachment 492019 [details] [diff] [review] patch Hmm, indeed, I think you're right!
Attachment #492019 -
Flags: review?(myk) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
https://github.com/mozilla/addon-sdk/commit/4c6bd864338e7522f07c1794d68b81f9c8996eab
Assignee: nobody → adw
Status: NEW → RESOLVED
Closed: 14 years ago
Component: General → Documentation
QA Contact: general → documentation
Resolution: --- → FIXED
Summary: remove "ready" event from Page Worker API → remove "ready" event from Page Worker API doc
Target Milestone: -- → 0.10
|
|
Reporter | |
Updated•13 years ago
|
Target Milestone: 0.10 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•