612727 - Move Sync Tools menuitems to a new overlay for browser and MailNews main window

Status: NEW

(SeaMonkey :: Sync UI, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

The initial Sync UI port (bug 576970) adds the two Sync menuitems to each and every Tools menu (through tasksOverlay.xul) but hides them by default, only to let the attached broadcasters unhide them selectively wherever gSyncUI is initialized. This has the desired effect of only showing them in the browser and MailNews main window (where the Sync toolbar icon is also available), but it's a bit unclean since the menuitems are always in the XUL, irrespective of whether they are actually usable in that context.

This bug is a for creating a new Sync-specific overlay, moving both the two menuitems and the two broadcasters to it, and adding it to both navigator.xul (navigatorOverlay.xul?) and messenger.xul so that it is loaded after tasksOverlay.xul.

Comment 1

[Philip Chee]

navigator.xul loads navigatorOverlay.xul anyway so the latter would be sufficient.

Comment 2

[Stefan [:stefanh]]

Putting bug 628404, comment #0 here, so it doesn't get lost:
--------------------------------------------------------------
2. When all windows are closed, there's an error message (see below) because the initial implementation doesn't cope with the Mac-specific hidden window case (the observer element referred to by the error message is contained in tasksOverlay.xul). Maybe this should be addressed in bug 612727.

Error: document.getElementById("sync-setup-state") is null
Source File: chrome://communicator/content/sync/syncUI.js
Line: 128
--------------------------------------------------------------

Comment 3

[Stefan [:stefanh]]

(In reply to Stefan [:stefanh] from comment #2)
> Putting bug 628404, comment #0 here, so it doesn't get lost:
Should of course be "Putting part 2 of bug 628404, comment #0 here"

Comment 4

[u510166]

[Tracking Requested - why for this release]: