612782 - [Versions page] Status for admin-disabled add-ons is incorrect

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. As an admin, disable an add-on and load its versions page- https://addons-next.allizom.org/z/en-US/developers/addon/247266/versions/

2. Notice the add-on status

expected behavior:
As per http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon/05_versions.png, the status should be "disabled by the admins"

actual behavior:
The status just says "disabled"

Comment 1

[Wil Clouser [:clouserw]]

When an add-on becomes STATUS_DISABLED it means it's admin disabled.  This is just a text change.

The "user disabled" state is a flag in the add-ons table called "inactive".  In remora we refer to this as "make your add-on inactive" - not disabling.  I think we chose that language on purpose, let's keep it.  This bug is for:

- text change for admin disabled
- text change for inactive add-ons

Comment 2

[Kumar McMillan [:kumar]]

This has been fixed in master https://github.com/jbalogh/zamboni/commit/50e90520ad6deb337b57bd4b891b10fc88dc9da9

Comment 3

[krupa raj[:krupa]]

User disabled add-ons also have the status- "Disabled by Admins"

See https://addons.allizom.org/z/en-US/developers/addon/255386/versions/

reopening

Comment 4

[Kumar McMillan [:kumar]]

Krupa, how did you user-disable this Add-on?  I'm not seeing the same result locally but maybe I disabled it wrong.  I was user-disabling by setting the flag to inactive in the db.

Comment 5

[krupa raj[:krupa]]

STR:

1. Load https://addons.allizom.org/z/en-US/developers/addon/64249/versions/
2. Notice the "Disable add-on" button

Owner of the add-on can disable the add-on by clicking on that button.

Comment 6

[Kumar McMillan [:kumar]]

Can't verify this until the UI for deactivating an add-on is fixed - bug 616213

Comment 7

[Kumar McMillan [:kumar]]

since bug 616213 is closed, this can be verified now.

However, an admin can no longer set an Addon-on's status to disabled on the versions page.  He/she would have to do so from the admin screen.  The versions page (per mock-up) just allows the developer or a super user to disable an Add-on.  Confusing, I know.  When a developer disables her addon it has the ability to retain its state (like pending review).

Comment 8

[krupa raj[:krupa]]

Filed bug 617192 

verified that on

a) disabling from the Versions page, the add-on status is "Disabled"
b) disabling from the admin panel, the add-on status is "Disabled by Admins"

https://addons.allizom.org/z/en-US/developers/addon/255394/versions/
https://addons.allizom.org/z/en-US/developers/addon/255393/versions/

Comment 9

[krupa raj[:krupa]]

Attachment: post-fix screenshot

Comment 10

[krupa raj[:krupa]]

Attachment: post-fix screenshot