Update review emails for new process

VERIFIED FIXED in 5.12.6

Status

addons.mozilla.org Graveyard
Admin/Editor Tools
P2
normal
VERIFIED FIXED
7 years ago
2 years ago

People

(Reporter: fligtar, Assigned: Barry Chen)

Tracking

Details

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
Created attachment 491099 [details]
review emails

We'll need to update our review email copy for the new process.

Jorge, please review the attached copy.
Attachment #491099 - Flags: feedback?(jorge)
Comment on attachment 491099 [details]
review emails

I wish Fire.fm could export stuff :(. But Remote XUL Manager will!

Looks good.
Attachment #491099 - Flags: feedback?(jorge) → feedback+
(Reporter)

Updated

7 years ago
Target Milestone: Q4 2010 → Q1 2011
(Reporter)

Comment 2

7 years ago
Seems like this was lost.
Target Milestone: Q1 2011 → 5.12.6
Assignee: nobody → chenba
(Assignee)

Comment 3

7 years ago
Created attachment 502764 [details] [diff] [review]
review e-mail changes patch

AFAIK, add-on slugs aren't in Remora, so the links in the e-mails still use add-on ids.
Attachment #502764 - Flags: review?(clouserw)
/addon/$slug is served by zamboni so we should be using it.  (It'll be a 404 if you only have remora installed, but with our hybrid code on allizom/mozilla it'll work fine.

Also, do you have if()'s around the "Tested on ___" string?  Otherwise, I think this is fine, please commit so we can test it.
Comment on attachment 502764 [details] [diff] [review]
review e-mail changes patch

r+ with stuff from comment 4
Attachment #502764 - Flags: review?(clouserw) → review+
(Assignee)

Comment 6

7 years ago
(In reply to comment #4)

Hmm right, I'll slugify the links.  Cakephp tends to grab everything so there shouldn't be additional work.

As for the platform+app string, those fields are not on the initial add-on review form, so it's not in the e-mail template for those review types.  They seem to be required for the update reviews, so if()'s are not necessary.  There weren't if()'s in the old Remora e-mail templates for that.  (But yes, I did see the if in Jorge's attachement.)
(Assignee)

Comment 7

7 years ago
Committed @ r80621.  Had to add 'slug' to the list of default fields in the model.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 8

7 years ago
I checked for all the review options and I got an appropriate email in each case.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.