612827 - [Authors & License page] Able to create blank authors

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P3)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://addons-next.allizom.org/z/en-US/developers/addon/182409/ownership
2. Add an author and save changes
3. Remove the new author's email-id and click save

observed behavior:
Able to save the empty author


headers:
https://addons-next.allizom.org/z/en-US/developers/addon/182409/ownership



POST /z/en-US/developers/addon/182409/ownership HTTP/1.1

Host: addons-next.allizom.org

User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12

Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8

Accept-Language: en,kn;q=0.7,en-us;q=0.3

Accept-Encoding: gzip,deflate

Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7

Keep-Alive: 115

Connection: keep-alive

Referer: https://addons-next.allizom.org/z/en-US/developers/addon/182409/ownership

Cookie: <removed>
Content-Type: application/x-www-form-urlencoded

Content-Length: 376

csrfmiddlewaretoken=eff2ee91fb058a9745204b54f49471db&form-TOTAL_FORMS=2&form-INITIAL_FORMS=1&form-MAX_NUM_FORMS=&form-0-user=krupa.raj%40gmail.com&form-0-role=5&form-0-listed=on&form-0-id=20086&form-0-position=0&form-1-user=&form-1-role=5&form-1-listed=on&form-1-id=&form-1-position=1&form-2-user=&form-2-role=5&form-2-position=&name=Custom+License&text=&eula=&privacy_policy=


HTTP/1.1 200 OK

Server: Apache

Vary: Cookie, Accept-Encoding

X-Backend-Server: pm-app-amo24

Cache-Control: no-cache

Content-Type: text/html; charset=utf-8

Content-Encoding: gzip

Date: Wed, 17 Nov 2010 07:28:19 GMT

Keep-Alive: timeout=5, max=1000

Transfer-Encoding: chunked

X-Content-Security-Policy-Report-Only: policy-uri /services/csp/policy

Via: Moz-Cache-pm-zlb-amo01

Connection: Keep-Alive

Set-Cookie: csrftoken=eff2ee91fb058a9745204b54f49471db; Max-Age=31449600; Path=/

Set-Cookie: multidb_pin_writes=y; Max-Age=15; Path=/

x-frame-options: DENY

Comment 1

[Jeff Balogh (:jbalogh)]

I only see one author on that page. Did you actually save the page with the empty author?

Comment 2

[Jeff Balogh (:jbalogh)]

I'm gonna go ahead and call this INVALID.  You were getting blocked by a hidden error that was fixed in bug 612760 by the masterful potch.

Comment 3

[krupa raj[:krupa]]

showed this bug to Jeff @ https://addons.allizom.org/z/en-US/developers/addon/64250/ownership

reopening

Comment 4

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commit/99eda55

Comment 5

[krupa raj[:krupa]]

verified @ https://addons.allizom.org/z/en-US/developers/addon/255394/ownership

On submitting a blank author, the field highlights in red and submission fails

Comment 6

[krupa raj[:krupa]]

Attachment: post-fix screenshot