Closed Bug 612900 Opened 9 years ago Closed 9 years ago

Cannot pan list of search engines when list is longer than viewable screen

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(fennec2.0b3+)

VERIFIED FIXED
Tracking Status
fennec 2.0b3+ ---

People

(Reporter: aakashd, Assigned: vingtetun)

Details

Attachments

(1 file, 1 obsolete file)

Build Id:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101117 Namoroka/4.0b8pre Fennec/4.0b3pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101117 Namoroka/4.0b8pre Fennec/4.0b3pre


Steps to Reproduce:
1. Go to http://mycroft.mozdev.org/search-engines.html
2. Add 10 search engines from that page
3. Tap on the url bar
4. Tap on the search button
5. Try to pan the list to get to the last search engine

Actual Results:
The list is not pannable.

Expected Results:
The list should be pannable.
tracking-fennec: --- → ?
Flags: in-testsuite?
Flags: in-litmus?
tracking-fennec: ? → 2.0b4+
Attached patch Patch (obsolete) — Splinter Review
The patch add scrolling to the arrowbox binding if needed, it also add a small fix for having the button text to crop at the end if they are too long to fit in the panel.
Attachment #493382 - Flags: review?(mark.finkle)
Comment on attachment 493382 [details] [diff] [review]
Patch

Check out the arrowbox.xml patch in bug 601751. Let's unify the patches:

* Using a field instead of <method name="handleEvent"> for "resize" event is supposed to be better for XBL that might be extended.
* Add the new code for resetting arrowbox.style.marginLeft / marginTop on "resize"
* Remove "_fadeTimer"
* Change the anonid: "panel-arrowcontent" -> "arrowcontent" and "panel-inner-arrowcontent" -> "inner-arrowcontent" (even though this element doesn't seem to need an anonid)

>+ this.style.minHeight = (window.innerHeight - parseInt(this.top) - 40) + "px";

Why the hard coded "40" ?
Attachment #493382 - Flags: review?(mark.finkle) → review-
Attached patch Patch v0.2Splinter Review
(In reply to comment #2)
> Check out the arrowbox.xml patch in bug 601751. Let's unify the patches:

This patch unify the 2 patches, but does not resolve the issue of bug 601751.

> * Using a field instead of <method name="handleEvent"> for "resize" event is
> supposed to be better for XBL that might be extended.

Addressed. Thinking of it, it makes sense to me, even if I dislike the new syntax, I would like having a super.handleEvent(aEvent)!

> 
> >+ this.style.minHeight = (window.innerHeight - parseInt(this.top) - 40) + "px";
> 
> Why the hard coded "40"A ?

I have switch from 40 to 64px. This is the size of the "margin" between the bottom of the window and the bottom of the arrowbox, it permits to always keep 64px of free space between them to see the content above the arrowbox.
Assignee: nobody → 21
Attachment #493382 - Attachment is obsolete: true
Attachment #493651 - Flags: review?(mark.finkle)
Attachment #493651 - Flags: review?(mark.finkle) → review+
Whiteboard: [fennec-checkin-postb3]
pushed:
http://hg.mozilla.org/mobile-browser/rev/75cb34e85ee3
Status: NEW → RESOLVED
tracking-fennec: 2.0b4+ → 2.0b3+
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fennec-checkin-postb3]
verified FIXED on build:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101210 Namoroka/4.0b8pre Fennec/4.0b3pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.