612900 - Cannot pan list of search engines when list is longer than viewable screen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101117 Namoroka/4.0b8pre Fennec/4.0b3pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101117 Namoroka/4.0b8pre Fennec/4.0b3pre


Steps to Reproduce:
1. Go to http://mycroft.mozdev.org/search-engines.html
2. Add 10 search engines from that page
3. Tap on the url bar
4. Tap on the search button
5. Try to pan the list to get to the last search engine

Actual Results:
The list is not pannable.

Expected Results:
The list should be pannable.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch add scrolling to the arrowbox binding if needed, it also add a small fix for having the button text to crop at the end if they are too long to fit in the panel.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 493382 [details] [diff] [review]
Patch

Check out the arrowbox.xml patch in bug 601751. Let's unify the patches:

* Using a field instead of <method name="handleEvent"> for "resize" event is supposed to be better for XBL that might be extended.
* Add the new code for resetting arrowbox.style.marginLeft / marginTop on "resize"
* Remove "_fadeTimer"
* Change the anonid: "panel-arrowcontent" -> "arrowcontent" and "panel-inner-arrowcontent" -> "inner-arrowcontent" (even though this element doesn't seem to need an anonid)

>+ this.style.minHeight = (window.innerHeight - parseInt(this.top) - 40) + "px";

Why the hard coded "40" ?

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

(In reply to comment #2)
> Check out the arrowbox.xml patch in bug 601751. Let's unify the patches:

This patch unify the 2 patches, but does not resolve the issue of bug 601751.

> * Using a field instead of <method name="handleEvent"> for "resize" event is
> supposed to be better for XBL that might be extended.

Addressed. Thinking of it, it makes sense to me, even if I dislike the new syntax, I would like having a super.handleEvent(aEvent)!

> 
> >+ this.style.minHeight = (window.innerHeight - parseInt(this.top) - 40) + "px";
> 
> Why the hard coded "40"A ?

I have switch from 40 to 64px. This is the size of the "margin" between the bottom of the window and the bottom of the arrowbox, it permits to always keep 64px of free space between them to see the content above the arrowbox.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/75cb34e85ee3

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101210 Namoroka/4.0b8pre Fennec/4.0b3pre

Comment 6

[Ayan Shah[:ashah]]

https://litmus.mozilla.org/show_test.cgi?id=15031