612965 - Open search results in foreground

Status: RESOLVED INVALID

(Firefox :: Search, defect)

Description

[Robert Kaiser]

See bug 600244 comment #3 and following:

IMHO, opening tabs from the UI is different from opening them from a web page in that you are not reading content when issuing the page load from the UI, and so opening a search from the search bar should not make the results page hidden in the background but open it in the foreground instead.

The patch for this is easy, but I think it might need UX input.

Comment 1

[Robert Kaiser]

Attachment: bring it into foreground

This is a patch based on bug 600244 - Gavin, do we need ui-r for this, or how is this going to work? Or is this completely unwanted?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

The code in question is the function that handles "Search for <selected text>" context menu item, it isn't related to the search bar...

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 491273 [details] [diff] [review]
bring it into foreground

...so it should obey browser.tabs.loadInBackground, the same way "open link in new tab" does.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment 0 is based on a false premise, so I think that makes this invalid. Reopen if I've misunderstood!