Closed
Bug 612985
Opened 14 years ago
Closed 14 years ago
Selecting text of a tweet in tweet list triggers overlays
Categories
(support.mozilla.org :: Army of Awesome, task, P3)
support.mozilla.org
Army of Awesome
Tracking
(Not tracked)
VERIFIED
FIXED
2.3.2
People
(Reporter: williamr, Assigned: erik)
References
()
Details
(Whiteboard: 2.3.1+)
Selecting text of a tweet in tweet list shouldn't trigger the reply window or sign in overlay. We should add a special case so these events aren't triggered when text has been selected.
|
Reporter | |
Comment 1•14 years ago
|
||
Jesse mentioned that checking window.getSelection after the mouse is clicked to see if text has been selected might be able to fix this.
|
||
Updated•14 years ago
|
Whiteboard: 2.3.1+
|
|
||
Updated•14 years ago
|
Target Milestone: 2.3.1 → 2.3.2
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → erik
|
|
Assignee | |
Comment 2•14 years ago
|
||
Fixed on master (https://github.com/jsocol/kitsune/commit/956f198cdd209444fa7072e4393f6c7624205f49). Fix on 2.3.2 is on its way; there are conflicts to resolve.
|
|
Assignee | |
Comment 3•14 years ago
|
||
Fixed on 2.3.2 also: https://github.com/jsocol/kitsune/commit/d04909d3d89b6099b7876c77bf35a3e4fb1ea8d4
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•