613033 - Delete addon failed

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Andy McKay]

Trying to delete an addon from:

/en-US/developers/addon/228511/versions/

Gave me:

Traceback (most recent call last):
  File "/Users/andy/sandboxes/zamboni/vendor/src/django/django/core/servers/basehttp.py", line 280, in run
    self.result = application(self.environ, self.start_response)
  File "/Users/andy/sandboxes/zamboni/vendor/src/django/django/core/servers/basehttp.py", line 674, in __call__
    return self.application(environ, start_response)
  File "/Users/andy/sandboxes/zamboni/vendor/src/django/django/core/handlers/wsgi.py", line 241, in __call__
    response = self.get_response(request)
  File "/Users/andy/sandboxes/zamboni/vendor/src/django/django/core/handlers/base.py", line 141, in get_response
    return self.handle_uncaught_exception(request, resolver, sys.exc_info())
  File "/Users/andy/sandboxes/zamboni/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "/Users/andy/sandboxes/zamboni/apps/amo/decorators.py", line 77, in wrapper
    return f(*args, **kw)
  File "/Users/andy/sandboxes/zamboni/apps/amo/decorators.py", line 69, in wrapper
    return f(*args, **kw)
  File "/Users/andy/sandboxes/zamboni/apps/amo/decorators.py", line 24, in wrapper
    return func(request, *args, **kw)
  File "/Users/andy/sandboxes/zamboni/apps/devhub/views.py", line 56, in wrapper
    return fun()
  File "/Users/andy/sandboxes/zamboni/apps/devhub/views.py", line 52, in <lambda>
    fun = lambda: f(request, addon_id=addon_id, addon=addon, *args, **kw)
  File "/Users/andy/sandboxes/zamboni/apps/devhub/views.py", line 72, in wrapper
    return f(request, addon_id, addon, *args, **kw)
  File "/Users/andy/sandboxes/zamboni/apps/devhub/views.py", line 241, in delete
    addon.delete('Removed via devhub')
  File "/Users/andy/sandboxes/zamboni/vendor/src/django/django/db/transaction.py", line 299, in _commit_on_success
    res = func(*args, **kw)
  File "/Users/andy/sandboxes/zamboni/apps/addons/models.py", line 224, in delete
    BlacklistedGuid(guid=self.guid, comments=msg).save()
  File "/Users/andy/sandboxes/zamboni/vendor/src/django/django/db/models/base.py", line 435, in save
    self.save_base(using=using, force_insert=force_insert, force_update=force_update)
  File "/Users/andy/sandboxes/zamboni/vendor/src/django/django/db/models/base.py", line 528, in save_base
    result = manager._insert(values, return_id=update_pk, using=using)
  File "/Users/andy/sandboxes/zamboni/vendor/src/django/django/db/models/manager.py", line 195, in _insert
    return insert_query(self.model, values, **kwargs)
  File "/Users/andy/sandboxes/zamboni/vendor/src/django/django/db/models/query.py", line 1479, in insert_query
    return query.get_compiler(using=using).execute_sql(return_id)
  File "/Users/andy/sandboxes/zamboni/vendor/src/django/django/db/models/sql/compiler.py", line 783, in execute_sql
    cursor = super(SQLInsertCompiler, self).execute_sql(None)
  File "/Users/andy/sandboxes/zamboni/vendor/src/django/django/db/models/sql/compiler.py", line 727, in execute_sql
    cursor.execute(sql, params)
  File "/Users/andy/sandboxes/zamboni/vendor/src/django/django/db/backends/util.py", line 15, in execute
    return self.cursor.execute(sql, params)
  File "/Users/andy/sandboxes/zamboni/vendor/src/django/django/db/backends/mysql/base.py", line 86, in execute
    return self.cursor.execute(query, args)
  File "/Users/andy/.virtualenvs/zamboni/lib/python2.6/site-packages/MySQLdb/cursors.py", line 173, in execute
    self.errorhandler(self, exc, value)
  File "/Users/andy/.virtualenvs/zamboni/lib/python2.6/site-packages/MySQLdb/connections.py", line 36, in defaulterrorhandler
    raise errorclass, errorvalue
IntegrityError: (1048, "Column 'guid' cannot be null")

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening; similar stack trying to delete https://addons.mozilla.org/en-US/developers/addon/a9-9331/versions/

Comment 2

[Jeff Balogh (:jbalogh)]

Sounds like a problem deleting search engines (which don't have a guid).

Comment 3

[krupa raj[:krupa]]

nominating for 5.12.9

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commit/3ac9dee

Comment 5

[krupa raj[:krupa]]

verified that deleting the following works fine:

* search engine awaiting review
* incomplete search engine
* disabled search engine

Also, checked that we didn't regress deleting extensions.