613039 - Activity feeds are missing icons

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P4)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
 Notice the activity feeds at https://addons-next.allizom.org/z/en-US/developers/feed/64250


As per http://people.mozilla.com/~chowse/drop/amo/devtools/v2/Activity_Feed.png, 

- Each activity feed should have an (default)add-on icon 
- Each activity should have an associated icon(like a thumbs up for approved etc)

observed behavior:
Activity feeds have no icons. See screenshot

Comment 1

[Wil Clouser [:clouserw]]

-> Chowse for images.  Once we have those, -> davedash for implementation

Comment 2

[Chris Howse [:chowse]]

Attachment: Feed Icon Sprite

Here are icons that should provide good activity coverage. Here's what each corresponds to:

1. Generic activity (anything that doesn't match any category below)
2. Reviews added/updated/removed
3. Tags added/changed/removed
4. Add-on added/removed from collections
5. Add-on edited (including description, version, payments, etc.)
6. Add-on or version added
7. Add-on or version deleted
8. Add-on approved
9. Add-on rejected

Comment 3

[Chris Howse [:chowse]]

Attachment: Feed Icon Sprite

Updated sprite, layed out vertically instead of horizontally.

Each icon begins on a multiple of 32px.
For example, you could use CSS like this:


.icon { background: url(feed-icons.png) no-repeat 0 0; }

.icon.review     { background-position: 0 -32px; }
.icon.tag        { background-position: 0 -64px; }
.icon.collection { background-position: 0 -96px; }
.icon.edit       { background-position: 0 -128px; }
.icon.add        { background-position: 0 -160px; }
.icon.delete     { background-position: 0 -192px; }
.icon.approve    { background-position: 0 -224px; }
.icon.reject     { background-position: 0 -256px; }

Comment 4

[Wil Clouser [:clouserw]]

thanks

Comment 5

[Christopher Van Wiemeersch [:cvan]]

https://github.com/jbalogh/zamboni/commit/ad7bdf1

Comment 6

[krupa raj[:krupa]]

- Feed for adding a new author has the icon "+" which is for adding a new add-on/version. Do we care?

- Feed for changing the license information has the edit icon(#5 in comment 2). Should it be (#1)?

Comment 7

[krupa raj[:krupa]]

Attachment: screenshot

Comment 8

[Wil Clouser [:clouserw]]

those both sound correct to me.

Comment 9

[krupa raj[:krupa]]

I do not know whether we plan to retroactively add icons to all activity feeds. but this seems fixed.

Comment 10

[krupa raj[:krupa]]

Attachment: post-fix screenshot