Closed Bug 613080 Opened 9 years ago Closed 9 years ago

External URL handler service

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set

Tracking

(fennec2.0+)

VERIFIED FIXED
Tracking Status
fennec 2.0+ ---

People

(Reporter: alexp, Assigned: alexp)

References

Details

Attachments

(1 file, 1 obsolete file)

On Android applications may handle some specific URLs, for example YouTube Player can open URLs like http://www.youtube.com/watch?v=GUdvHJFsr1k.
We need to support this by allowing the user to pass URLs to the applications, which can handle them.
Assignee: nobody → alexp
Blocks: 599636
Status: NEW → ASSIGNED
tracking-fennec: --- → ?
Attached patch Fix (obsolete) — Splinter Review
nsIExternalURLHandlerService implementation.
Attachment #491379 - Flags: review?(blassey.bugs)
Seems like we should be adapting the existing external protocol handling for this.
Attachment #491379 - Flags: review?(blassey.bugs) → review?(dwitte)
(In reply to comment #2)
> Seems like we should be adapting the existing external protocol handling for
> this.

Actually it would make sense, as it's basically the same, at least on Android.
Comment on attachment 491379 [details] [diff] [review]
Fix

Probably best looked at by bz.
Attachment #491379 - Flags: review?(dwitte) → review?(bzbarsky)
Comment on attachment 491379 [details] [diff] [review]
Fix

>+#define NS_EXTERNALURLHANDLERSERVICE_CONTRACTID "@mozilla.org/uriloader/external-url-handler-service;1"
>+#define NS_IEXTERNALURLHANDLERSERVICE_CLASSNAME "Mozilla URL Handler Service"

Those should go in nsDocShellCID.h

>+ * You can ask the service if it has an external handler for a given URL.
>+ * And you can ask it to load the URL using the default handler.

How, exactly?

Would it make sense to take an nsIURI for the url here?

This code is still unused at this point, right?  What do the consumers look like?
(In reply to comment #5)
> >+ * You can ask the service if it has an external handler for a given URL.
> >+ * And you can ask it to load the URL using the default handler.
> 
> How, exactly?

Oh, this half of the comment should be just removed. Originally there was a thought to have one or two additional methods similar to nsIExternalProtocolService.

> Would it make sense to take an nsIURI for the url here?

Yes, I guess it would.

> This code is still unused at this point, right?  What do the consumers look
> like?

This is a proposed backend for bug 599636 - please see there a WIP patch for Android, which uses this interface. The final implementation there will probably be using a context menu.
Comment on attachment 491379 [details] [diff] [review]
Fix

> Oh, this half of the comment should be just removed. 

Please do that, yeah.

r=me with the nits addressed.
Attachment #491379 - Flags: review?(bzbarsky) → review+
tracking-fennec: ? → 2.0b3+
tracking-fennec: 2.0b3+ → 2.0+
Attached patch Fix v2Splinter Review
Fixed the nits.
r=bz
Attachment #491379 - Attachment is obsolete: true
Attachment #492838 - Flags: review+
pushed http://hg.mozilla.org/mozilla-central/rev/9d578b3cff83
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified fixed on the 12/27 nightly
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Flags: in-litmus?
https://litmus.mozilla.org/show_test.cgi?id=15186
Flags: in-litmus? → in-litmus?(ioana.chiorean)
Flags: in-litmus?(ioana.chiorean) → in-litmus+
You need to log in before you can comment on or make changes to this bug.