613080 - External URL handler service

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Alex Pakhotin (:alexp)]

On Android applications may handle some specific URLs, for example YouTube Player can open URLs like http://www.youtube.com/watch?v=GUdvHJFsr1k.
We need to support this by allowing the user to pass URLs to the applications, which can handle them.

Comment 1

[Alex Pakhotin (:alexp)]

Attachment: Fix

nsIExternalURLHandlerService implementation.

Comment 2

[Michael Wu [:mwu]]

Seems like we should be adapting the existing external protocol handling for this.

Comment 3

[Alex Pakhotin (:alexp)]

(In reply to comment #2)
> Seems like we should be adapting the existing external protocol handling for
> this.

Actually it would make sense, as it's basically the same, at least on Android.

Comment 4

[[e-mail]]

Comment on attachment 491379 [details] [diff] [review]
Fix

Probably best looked at by bz.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 491379 [details] [diff] [review]
Fix

>+#define NS_EXTERNALURLHANDLERSERVICE_CONTRACTID "@mozilla.org/uriloader/external-url-handler-service;1"
>+#define NS_IEXTERNALURLHANDLERSERVICE_CLASSNAME "Mozilla URL Handler Service"

Those should go in nsDocShellCID.h

>+ * You can ask the service if it has an external handler for a given URL.
>+ * And you can ask it to load the URL using the default handler.

How, exactly?

Would it make sense to take an nsIURI for the url here?

This code is still unused at this point, right?  What do the consumers look like?

Comment 6

[Alex Pakhotin (:alexp)]

(In reply to comment #5)
> >+ * You can ask the service if it has an external handler for a given URL.
> >+ * And you can ask it to load the URL using the default handler.
> 
> How, exactly?

Oh, this half of the comment should be just removed. Originally there was a thought to have one or two additional methods similar to nsIExternalProtocolService.

> Would it make sense to take an nsIURI for the url here?

Yes, I guess it would.

> This code is still unused at this point, right?  What do the consumers look
> like?

This is a proposed backend for bug 599636 - please see there a WIP patch for Android, which uses this interface. The final implementation there will probably be using a context menu.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 491379 [details] [diff] [review]
Fix

> Oh, this half of the comment should be just removed. 

Please do that, yeah.

r=me with the nits addressed.

Comment 8

[Alex Pakhotin (:alexp)]

Attachment: Fix v2

Fixed the nits.
r=bz

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/9d578b3cff83

Comment 10

[Aaron Train [:aaronmt]]

Verified fixed on the 12/27 nightly

Comment 11

[Ioana Chiorean]

https://litmus.mozilla.org/show_test.cgi?id=15186