613090 - [Manage Versions page] traceback at /z/en-US/developers/addon/252558/versions/121278

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

Traceback while attempting to set two files to have the same supported platform. I was unable to reproduce the traceback though.

traceback details:
File "/data/amo_python/www/next/zamboni/apps/amo/decorators.py", line 69, in wrapper
   return f(*args, **kw)

 File "/usr/lib/python2.6/contextlib.py", line 34, in __exit__
   self.gen.throw(type, value, traceback)

 File "/data/amo_python/www/next/zamboni/apps/amo/models.py", line 37, in skip_cache
   yield

 File "/data/amo_python/www/next/zamboni/apps/amo/decorators.py", line 69, in wrapper
   return f(*args, **kw)

 File "/data/amo_python/www/next/zamboni/apps/amo/decorators.py", line 24, in wrapper
   return func(request, *args, **kw)

 File "/data/amo_python/www/next/zamboni/apps/devhub/views.py", line 52, in wrapper
   return f(request, addon_id, addon, *args, **kw)

 File "/data/amo_python/www/next/zamboni/apps/devhub/views.py", line 448, in version_edit
   queryset=version.files.all())

 File "/data/amo_python/www/next/zamboni/vendor/src/django/django/forms/models.py", line 423, in __init__
   super(BaseModelFormSet, self).__init__(**defaults)

 File "/data/amo_python/www/next/zamboni/vendor/src/django/django/forms/formsets.py", line 47, in __init__
   self._construct_forms()

 File "/data/amo_python/www/next/zamboni/vendor/src/django/django/forms/formsets.py", line 97, in _construct_forms
   self.forms.append(self._construct_form(i))

 File "/data/amo_python/www/next/zamboni/vendor/src/django/django/forms/models.py", line 448, in _construct_form
   return super(BaseModelFormSet, self)._construct_form(i, **kwargs)

 File "/data/amo_python/www/next/zamboni/vendor/src/django/django/forms/formsets.py", line 116, in _construct_form
   form = self.form(**defaults)

 File "/data/amo_python/www/next/zamboni/apps/devhub/forms.py", line 318, in __init__
   status = kw['instance'].status

KeyError: 'instance'


<WSGIRequest
GET:<QueryDict: {}>,
POST:<QueryDict: {u'files-1-status': [u'1'], u'files-1-platform': [u'3'], u'files-0-id': [u'103074'], u'form-0-application': [u'1'], u'form-4-max': [u''], u'form-4-id': [u''], u'form-3-application': [u'59'], u'form-3-min': [u''], u'form-0-id': [u'94776'], u'files-0-platform': [u'3'], u'form-0-min': [u'218'], u'files-TOTAL_FORMS': [u'2'], u'releasenotes': [u''], u'form-4-min': [u''], u'form-3-max': [u''], u'form-2-id': [u''], u'form-1-id': [u''], u'csrfmiddlewaretoken': [u'eff2ee91fb058a9745204b54f49471db'], u'files-INITIAL_FORMS': [u'1'], u'form-1-max': [u''], u'files-MAX_NUM_FORMS': [u''], u'form-2-min': [u''], u'form-TOTAL_FORMS': [u'5'], u'form-1-min': [u''], u'form-INITIAL_FORMS': [u'1'], u'form-2-max': [u''], u'files-1-id': [u'103609'], u'form-0-max': [u'258'], u'form-3-id': [u''], u'files-0-status': [u'1'], u'form-2-application': [u'60'], u'form-1-application': [u'18'], u'form-MAX_NUM_FORMS': [u''], u'approvalnotes': [u''], u'form-4-application': [u'52']}>,

Comment 1

[Andy McKay]

I believe this occurs only when you try and upload a file. The rest of the time it's fine. We need to write an approriate unit test for this.

Comment 2

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/1c3ebdf48efe3e31f92efe6e755a5cf721b7a1df

Comment 3

[krupa raj[:krupa]]

verified fixed that there is no traceback while uploading an add-on file @ https://addons.allizom.org/z/en-US/developers/addon/a-place-where-the-sea-remem-2/versions/121917