#include inside a namespace block hinders eclipse CDT indexing

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: edwsmith, Assigned: edwsmith)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
eval.h uses this pattern:

namespace avmplus {
  namespace RTC {
    #include ...
  }
}

Don't ask me why, but if you put the #includes outside of a namespace, and replicate the namespace statements in each include file, CDT indexing works fine.
(Assignee)

Comment 1

8 years ago
Created attachment 491415 [details] [diff] [review]
Move eval's #includes out of namespace blocks.


Here's a patch.  I didn't indent, to minimize diffs and be friendly to narrow windows, but will indent or fix the close-block style on request.  I went for brevity:

  }}

but this would be more consistent

  } // namespace RTC
  } // namepsace avmplus
Assignee: nobody → edwsmith
Attachment #491415 - Flags: review?(lhansen)

Updated

8 years ago
Attachment #491415 - Flags: review?(lhansen) → review+

Comment 2

8 years ago
changeset: 5561:9990414f3836
user:      Edwin Smith <edwsmith@adobe.com>
date:      Thu Nov 18 12:37:20 2010 -0500
summary:   Bug 613112 - #include inside a namespace block hinders eclipse CDT indexing (r=lhansen)

http://hg.mozilla.org/tamarin-redux/rev/9990414f3836
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.