613112 - #include inside a namespace block hinders eclipse CDT indexing

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Edwin Smith]

eval.h uses this pattern:

namespace avmplus {
  namespace RTC {
    #include ...
  }
}

Don't ask me why, but if you put the #includes outside of a namespace, and replicate the namespace statements in each include file, CDT indexing works fine.

Comment 1

[Edwin Smith]

Attachment: Move eval's #includes out of namespace blocks.

Here's a patch.  I didn't indent, to minimize diffs and be friendly to narrow windows, but will indent or fix the close-block style on request.  I went for brevity:

  }}

but this would be more consistent

  } // namespace RTC
  } // namepsace avmplus

Comment 2

[Tamarin Bot]

changeset: 5561:9990414f3836
user:      Edwin Smith <[e-mail]>
date:      Thu Nov 18 12:37:20 2010 -0500
summary:   Bug 613112 - #include inside a namespace block hinders eclipse CDT indexing (r=lhansen)

http://hg.mozilla.org/tamarin-redux/rev/9990414f3836