613219 - transparent TestPilot popup/pop-up/notification (similar to Bad CSS on new study notifications)

Status: VERIFIED FIXED

(Mozilla Labs Graveyard :: Test Pilot, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

+++ This bug was initially created as a clone of Bug #574796 +++

Testpilot shows the notification for the end of the week in the life of a browser study by using a popup, but it's mostly transparent.

Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12

See screenshot.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: transparent notification

Comment 2

[Eitan Adler]

I tested on a clean profile but was unable to reproduce.

On my primary profile I did see this bug:

Reproduced with 


  Application Basics

        Name
        Firefox

        Version
        4.0b7

        User Agent
        Mozilla/5.0 (X11; FreeBSD i386; rv:2.0b7) Gecko/20100101 Firefox/4.0b7

        Profile Directory

          Open Containing Folder

        Enabled Plugins

          about:plugins

        Build Configuration

          about:buildconfig

  Extensions

        Name

        Version

        Enabled

        ID

        DownThemAll!
        1.1.10
        false
        {DDC359D1-844A-42a7-9AA1-88A850A938A8}

        HTTPS-Everywhere
        0.9.2
        true
        [e-mail]

        Adblock Plus
        1.3.1
        true
        {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}

        Stylish
        1.0.11
        false
        {46551EC9-40F0-4e47-8E18-8E5CF550CFB8}

        NoScript
        2.0.7
        true
        {73a6fe31-595d-460b-a920-fcc0f8843232}

        More Tools Menu
        1.2.1
        false
        {9a7a67d3-3048-47fb-acde-d0f7ae51f86a}

        Test Pilot
        1.0.3
        true
        [e-mail]

  Modified Preferences

      Name

      Value

        accessibility.typeaheadfind.flashBar
        0

        browser.history_expire_days.mirror
        180

        browser.history_expire_days_min
        200

        browser.places.importBookmarksHTML
        false

        browser.places.smartBookmarksVersion
        2

        browser.startup.homepage_override.buildID
        20101203143535

        browser.startup.homepage_override.mstone
        rv:2.0b7

        extensions.lastAppVersion
        4.0b7

        network.cookie.cookieBehavior
        1

        network.cookie.prefsMigrated
        true

        network.http.max-persistent-connections-per-server
        8

        places.history.expiration.transient_current_max_pages
        63644

        places.last_vacuum
        1286288643

        privacy.cpd.cache
        false

        privacy.cpd.downloads
        false

        privacy.cpd.formdata
        false

        privacy.cpd.history
        false

        privacy.cpd.sessions
        false

        privacy.sanitize.migrateFx3Prefs
        true

        privacy.sanitize.timeSpan
        0

        security.disable_button.openCertManager
        false

        security.warn_viewing_mixed
        false

  Graphics

      GPU Accelerated Windows
      0/4

Comment 4

[Tracy Walker [:tracy]]

I've haven't seen this on Windows, but I do see it on 3.6.12 using TP 1.0.3 on Ubuntu with a clean profile.  Just use the debug page - chrome://testpilot/content/debug.html and click Show Dummy Popup.

Comment 5

[Ryan Dunlop]

(In reply to comment #4)
> I've haven't seen this on Windows, but I do see it on 3.6.12 using TP 1.0.3 on
> Ubuntu with a clean profile.  Just use the debug page -
> chrome://testpilot/content/debug.html and click Show Dummy Popup.

Having the same issues in Win7 64bit.  FF 3.6.13 TP 1.0.3.  Will be checking it out on WinVista 32bit and Linux Mint 64bit when I have a minute tonight.  (only replying due to your comment "haven't see this on Windows")

Comment 6

[Jinghua zhang]

One user suggests that it is due to a division-by-zero error in the drawing code.

Comment 8

[Ryan Dunlop]

(In reply to comment #5)
> (In reply to comment #4)
> > I've haven't seen this on Windows, but I do see it on 3.6.12 using TP 1.0.3 on
> > Ubuntu with a clean profile.  Just use the debug page -
> > chrome://testpilot/content/debug.html and click Show Dummy Popup.
> 
> Having the same issues in Win7 64bit.  FF 3.6.13 TP 1.0.3.  Will be checking it
> out on WinVista 32bit and Linux Mint 64bit when I have a minute tonight.  (only
> replying due to your comment "haven't see this on Windows")

I have confirmed this happening in Linux Mint 64bit FF 3.6.13 TP 1.0.3 also.  On my Win7 64bit I now also have the FF 4 beta 10 and seems to work just fine.  FYI.

Comment 9

[Jono Xia]

I think I finally figured out what has been causing this.

The image file that is supposed to be used as the background for notifications, when showing the Test Pilot UI on Firefox 3.6.*, is chrome://testpilot/skin/notification-tail-down.png

If you try to load this URL on a profile affected by this bug, the file is not present.  On profiles that do not have that bug, the file is present!

What happened is that way back in June when I fixed https://bugzilla.mozilla.org/show_bug.cgi?id=574796 (which involved undoing an earlier change) I forgot to re-include skins/all/notification-tail-down.png into the Hg repository.  (Should have been included in http://hg.mozilla.org/labs/testpilot/rev/2a402eaba767 but was not.)

Since the file was present in my local working directory , it was included in XPI files built on my personal machine, but was not included in XPI files built from other checkouts of the Hg repo.  That's why it's been so hard to debug this: there are actually two versions of the Test Pilot 1.0.3 extension in the wild, and one of them (which appears to be the version currently on AMO) is lacking a key file.

Fixing the bug is as simple as putting the file back in, which I did in http://hg.mozilla.org/labs/testpilot/rev/9602e40ff946

I think that from now on we should always build XPIs from a fresh checkout of the repository, so that problems like this one will be detected earlier, before we release a new XPI.

Comment 10

[Jono Xia]

Attachment: Patch re-adding the missing file

Here is a patch re-adding the missing image file.

Comment 11

[Dave Townsend [:mossop]]

Comment on attachment 513209 [details] [diff] [review]
Patch re-adding the missing file

Landed: http://hg.mozilla.org/mozilla-central/rev/cd63bb369f1c

Comment 12

[Tracy Walker [:tracy]]

looks fine for me with 1.1pre5

Comment 13

[Ryan Dunlop]

Fixed the issue on my end.  Good find!