613287 - video controls should "push in" when tapped

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Madhava Enros [:madhava]]

So, we need pushed in states of the images, and also to make them go.

Comment 1

[Sean Martell]

for the video controls, if we offset them down 3px or so, and set their opacity to 40%, they would look pressed.

Let's try that.  might not need extra assets.

Comment 2

[[:fabrice] Fabrice Desré]

Attachment: wip

Not working yet, looks like the :hover:active rule never triggers...

Comment 3

[Wesley Johnston (:wesj)]

I just pushed the patch to set active on elements when they are tapped. Should work now?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #3)
> I just pushed the patch to set active on elements when they are tapped. Should
> work now?

Does this work on video controls?

Comment 5

[Wesley Johnston (:wesj)]

The active style isn't applied to the controls, since they are anonymous. Instead it is applied to the video. We do fire hover a second later, but most taps on the controls are to quick for that to happen.

Also, the wip should note that there is already a transform applied to the play button that needs to be taken into account during the active state.

Comment 6

[Aaron Train [:aaronmt]]

Still present in current builds

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

filter on [mass-p5]

Comment 8

[:Margaret Leibovic]

This is old, we can file a new bug if we want to do this ever.