Closed Bug 613324 Opened 9 years ago Closed 9 years ago

update WebGL constants

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bjacob, Assigned: bjacob)

Details

Attachments

(2 files)

The spec changed a bit. This makes us pass the constants.html test except for the VIEWPORT stuff which is a different story (bug 586938).
Attachment #491644 - Flags: review?(vladimir)
OS: Linux → All
Hardware: x86_64 → All
Comment on attachment 491644 [details] [diff] [review]
Fix WebGL constants

I don't actually think you need any of the #defines at the start of WebGLContext.h -- in fact, they would cause problems if they were #defined before including nsIDOMRenderingContextWebGL.h.  Either prefix them with GL (or LOCAL_GL_, I guess, for consistency -- can just add them to gldefs.h), or you should be able to get rid of them since the enums should be visible in the subclass...
Attachment #491644 - Flags: review?(vladimir) → review+
Yes indeed, that works!

carrying forward r+
Attachment #491943 - Flags: review+
Attachment #491943 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/367ff816f171
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee: nobody → bjacob
You need to log in before you can comment on or make changes to this bug.