613337 - Media gallery gives no warning when deleting an image in use

Status: RESOLVED WONTFIX

(support.mozilla.org :: Knowledge Base Software, task, P4)

Description

[Rebecca Billings [:rbillings]]

There is no warning given when a user deletes an image from the media gallery when it has already been included in kb articles.

1) add image to media gallery
2) create or edit kb article> insert media> add new image
3) return to media gallery> delete new image

expected: warning that image is in use [outside of saying this is a permanent delete]
actual: permanent delete warning only

Comment 1

[James Socol [:jsocol, :james]]

If we weren't past the string freeze I'd suggest making the warning more severe for now. We don't have a quick way of querying this data right now without scanning the whole revisions table.

Comment 2

[[:Cww]]

Can we not give the delete image permission to contributors by default? We'll make it an admin-only thing for now and allow deleting once we fix this bug.

Comment 3

[Paul Craciunoiu [:paulc]]

Anyone can delete their own images/videos. Other than that, they need to have the gallery.delete_image/video permission.

Comment 4

[Alice Wyman]

This is a very old bug that needs to be resolved.  

See my 2013-08-30 comment in Bug 909824 - Allow Forum Mods to remove images from the Image Gallery.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

We already show a warning step when deleting an image. We just need to add a note about the articles where it is being used in (just like we have on the image details page).

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Moving our P4s to the backlog.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Q1 is over. Bring it on, Q2!

Comment 8

[Rebecca Billings [:rbillings]]

With SUMO changes, closing as won't fix.