jetpack-core should be renamed to api-utils

RESOLVED FIXED

Status

Add-on SDK
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: myk, Assigned: myk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
The jetpack-core package should be renamed to api-utils to better reflect its purpose.

Updated

7 years ago
Duplicate of this bug: 595407
(Assignee)

Comment 2

7 years ago
We should do this as one of the last changes we make before shipping the first 1.0b1 release candidate to avoid rotting a bunch of blocker patches.
(Assignee)

Comment 3

7 years ago
Since this should be done right before spinning the RC, which I'll be doing, I'll take this on.  Note that this is much more than simply renaming the directory, as there are a bunch of (primarily documentation and test) files that reference "jetpack-core" , and there's even a second directory with that name at python-lib/cuddlefish/tests/static-files/packages/jetpack-core.
Assignee: nobody → myk
Status: NEW → ASSIGNED
(Assignee)

Comment 4

7 years ago
Created attachment 494223 [details]
pull request #67v1: makes changes

Here's a set of commits that makes the necessary changes.
Attachment #494223 - Flags: review?(warner-bugzilla)
Attachment #494223 - Flags: review?(avarma)
(Assignee)

Updated

7 years ago
Attachment #494223 - Attachment is patch: false
Attachment #494223 - Attachment mime type: text/plain → text/html

Comment 5

7 years ago
This looks great! It's also the first time in a while for me that we're running with all tests passing on ff4.0b7 and the latest nightly. Woo!

Pushed:

https://github.com/mozilla/addon-sdk/commit/0727c3a1c3b7da6f64234042f211786ee5b28841
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Attachment #494223 - Flags: review?(warner-bugzilla)
Attachment #494223 - Flags: review?(avarma)
You need to log in before you can comment on or make changes to this bug.