613391 - "push" command needs buffering in SUTAgentPython

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Mark Côté [:mcote]]

The "push" command doesn't work properly if the commands arrive too quickly to the agent.  The handle() method reads up to 1024 bytes, which may include the file data itself.  But the push() function reads directly from the socket, so it might miss some of the data.  So the data needs to be buffered and read from the buffer first before going back to the socket.

There are also a few smaller bugs:
- the params aren't counted
- need support for new "isdir" command
- allow_reuse_addr should be set so that the agent can be restarted quickly.

Comment 1

[Mark Côté [:mcote]]

Attachment: Patch for buffering socket data and other small fixes

Comment 2

[Mark Côté [:mcote]]

Attachment: Patch for buffering socket data, new pull command, and other small fixes

Okay this patch is as the previous, but it also implements the new "pull" command that was recently added to the Android agent.  I also made the cd command not print out the cwd, since the Android agent doesn't.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 493047 [details] [diff] [review]
Patch for buffering socket data, new pull command, and other small fixes

>diff --git a/SUTAgentPython/test-agent.py b/SUTAgentPython/test-agent.py
>@@ -155,17 +185,17 @@ class ThreadedTestHandler(SocketServer.
>-    for part in parts[1+int(num_options):]:
>+    for part in parts[1+int(num_options):1+int(num_options)+(num_params)]:

we should put int(num_params) to be safe here


r+ with that change made.

Comment 4

[Mark Côté [:mcote]]

Right, good catch.  Committed, with that fix.