613440 - Cannot load ICM profile if profile path is non-ASCII

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect)

Description

[Makoto Kato [:m_kato]]

http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxWindowsPlatform.cpp?mark=617-632#617

631     qcms_profile* profile =
632         qcms_profile_from_path(NS_ConvertUTF16toUTF8(str).get());

http://mxr.mozilla.org/mozilla-central/source/gfx/qcms/iccread.c?mark=813-816#813

813 qcms_profile* qcms_profile_from_path(const char *path)
814 {
815         qcms_profile *profile = NULL;
816         FILE *file = fopen(path, "rb");

ANSI C function on Windows cannot handle UTF8 path.  It uses native charset such as Shift JIS.  We should use wide C function on Windows without conversion.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Makoto Kato [:m_kato]]

Attachment: fix v1.1

Comment 3

[Benoit Girard (:BenWa)]

I think it would be cleaner if the platform specific logic wasn't exposed by the interface (by having specifics profile_from method) but if it was rather handled internally in qcms_profile_from_path.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #3)
> I think it would be cleaner if the platform specific logic wasn't exposed by
> the interface (by having specifics profile_from method) but if it was rather
> handled internally in qcms_profile_from_path.

The problem with this approach is that it's not clear to me what the type of the path parameter should be. Currently, the path parameter's definition matches fopen. Since, fopen is broken on Windows I think it makes sense to expose a separate function that uses wfopen.

Comment 6

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/projects/cedar/rev/74729ced9c59

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/74729ced9c59