6135 - Crash on nsPluginsDirWin.cpp

Status: CLOSED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[leger]

Hello - you have crashed using a recent mozilla build in the plug-ins area.
Could you give us an idea of plug-ins you are using so that we can try to
isolate the bug?  Thanks!

- Please respond at http://bugzilla.mozilla.org/. Bug# to be added shortly.
- If you do not have a Bugzilla account, please sign up for one and put feedcak
for us into Additional Comment and click Commit Button.

amusil, stack crawl for bug:
Call Stack:    (Signature = CalculateVariantCount 3f7d71fb)
    CalculateVariantCount
       [d:\builds\seamonkey\mozilla\modules\plugin\nglsrc\nsPluginsDirWin.cpp,
line 72]
    nsPluginFile::GetPluginInfo
       [d:\builds\seamonkey\mozilla\modules\plugin\nglsrc\nsPluginsDirWin.cpp,
line 293]
    nsPluginHostImpl::LoadPlugins
       [d:\builds\seamonkey\mozilla\modules\plugin\nglsrc\nsPluginHostImpl.cpp,
line 1804]
    nsPluginHostImpl::GetPluginFactory
        [d:\builds\seamonkey\mozilla\modules\plugin\nglsrc\nsPluginHostImpl.cpp,
line 1745]
    nsJVMManager::StartupJVM
         [d:\builds\seamonkey\mozilla\modules\oji\src\nsJVMManager.cpp, line
552]
    nsJVMManager::MaybeStartupLiveConnect
         [d:\builds\seamonkey\mozilla\modules\oji\src\nsJVMManager.cpp, line
688]
    nsJVMManager::StartupLiveConnect
          [d:\builds\seamonkey\mozilla\modules\oji\src\nsJVMManager.h, line 147]
    nsJSEnvironment::nsJSEnvironment
          [d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp, line
406]
    nsJSEnvironment::GetScriptingEnvironment
          [d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp, line
389]
    NS_CreateContext
          [d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp, line
429]
    nsWebShell::CreateScriptEnvironment
          [d:\builds\seamonkey\mozilla\webshell\src\nsWebShell.cpp, line 2204]
    nsWebShell::GetScriptGlobalObject
          [d:\builds\seamonkey\mozilla\webshell\src\nsWebShell.cpp, line 2230]
    DocumentViewerImpl::Init
           [d:\builds\seamonkey\mozilla\webshell\src\nsDocumentViewer.cpp, line
300]
    nsWebShell::Embed
          [d:\builds\seamonkey\mozilla\webshell\src\nsWebShell.cpp, line 738]
    nsDocumentBindInfo::OnStartBinding
          [d:\builds\seamonkey\mozilla\webshell\src\nsDocLoader.cpp, line 2001]
    OnStartBindingProxyEvent::HandleEvent
         [d:\builds\seamonkey\mozilla\network\module\nsNetThread.cpp, line 506]
    StreamListenerProxyEvent::HandlePLEvent
          [d:\builds\seamonkey\mozilla\network\module\nsNetThread.cpp, line 472]
    PL_HandleEvent  [plevent.c, line 477]
    PL_ProcessPendingEvents   [plevent.c, line 438]
    _md_EventReceiverProc  [plevent.c, line 803]
    KERNEL32.DLL + 0x3663 (0xbff73663)
    KERNEL32.DLL + 0x22894 (0xbff92894)
    0x00778c54

Comment 1

[Alex Musil]

From looking at the code I have surmised where the crash might be occuring and I
have checked in a fix.

It looks like a certain plugin is not registering its mimetypes correctly - the
code did not previously handle this situation and a null pointer gets
dereferenced.  I have added some error checking to handle this.

If someone can point me to the plugin that exhibited this problem, I can test the
fix fully.

Comment 2

[Jan Eldenmalm]

sorry,

bad report.. the apprunner application was the problem....

I never managed to start it at all... if it is looking in any of my plugin
directories(NN4) it will find the following dll's:
npaudio
npavi32
NPBeatnk
NPBatSP
npdsplay
npjava32
npnul32
nppdf32
npPhoneFree
nppl3260
Npqtw32

NN4.5:
same as above and
npswf32
and NPBeatSp with no exxtention.

NN3
same as NN4
and ShockwavePlugin.class

Comment 3

[Alex Musil]

Please try removing the npjava32.dll and see if it still crashes on start up.

Comment 4

[leger]

Try the latest build. This crash no longer happens :-)

Comment 5

[leger]

Apprunner component being deleted/retired at end of week.  Moving all Apprunner
bugs past and present to another appropriate component.