613545 - after each context menu test, wait until context menu popup hidden before moving on to next test

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: explicitly closes context menu

While investigating the test failure in bug 603907, I noticed that the context menu tests don't explicitly close the context menu after they are finished running.  I tried explicitly closing them to see if it would fix the test failure, but it didn't.  Nevertheless, I have this patch, so I thought I would check to see if it seems like something we ought to be doing anyway for good measure.

Drew: what do you think?

Comment 1

[Drew Willcoxon :adw]

Comment on attachment 491886 [details] [diff] [review]
patch v1: explicitly closes context menu

Thanks!  Just to be clear, the context menu is actually explicitly closed before each test finishes -- I made sure of that.  What I didn't make sure of, and what your patch really does, and what I think is a good idea, is to wait until popuphidden is fired before moving on to the next test. :)

Comment 2

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #1)
> Just to be clear, the context menu is actually explicitly closed
> before each test finishes -- I made sure of that.  What I didn't make sure of,
> and what your patch really does, and what I think is a good idea, is to wait
> until popuphidden is fired before moving on to the next test. :)

Yup, good point, updating the bug summary accordingly.

https://github.com/mozilla/addon-sdk/commit/2391f2503c89e5503838bc02a4f1090b4d4fcab9

https://github.com/mozilla/addon-sdk/commit/85b01b53c943fc175372526d2386887c5a6fca4b

(rebase/merge bungling)