613562 - VKB will stay open in portrait mode when going to the preference panel

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Mozilla/5.0 (Android; Linux armv71; rv2.0b8pre) Gecko/20101119 Firefox/4.0b8pre Fennec/4.0b3pre

1. close the hardware keyboard
2. place device in portrait mode
3. go to google.com
4. click in the text field
5. open the control side panel
6. click on the gears to bring up the preferences panel

Expected: VKB will disappear
Actual: VKB stays open

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Sounds like we need to Deactivate the browser when the broadcaster changes

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch + tests

Regression from bug 589337. The patch fix the bug and I've added a few tests for those type of bugs

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's get this in b3 since it is a regression

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/000351e28041

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Please check bug 613635 when regressing this bug.

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101129 Namoroka/4.0b8pre Fennec/4.0b3pre