Closed Bug 613617 Opened 10 years ago Closed 10 years ago

Addon UI: Update to simplify crypto

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: philikon, Assigned: philikon)

References

Details

Attachments

(1 file, 2 obsolete files)

+++ This bug was initially created as a clone of Bug #612699 +++

This entails:

* Surface a notification for existing Sync users that a new Sync Key has been generated from their old Sync Key/passphrase. They don't need to do anything on their other machines, but their old Sync Key/passphrase is no longer valid.

* The account creation wizard won't allow you to set a custom passphrase, it just shows a generated one.

* The My Sync Key dialog no longer allows you to set a custom passphrase, it just allows you to generate a new one.

* Everywhere Sync Keys are shown and entered we need to aid the user with hyphens. The hyphenation/dehyphenation should happen in Weave.Util.* helpers, the UI code shouldn't have to know about specific Sync Key formats.

* Since we're ripping out custom passphrases we can also rip out the whole Sync
Key strength meter thingie. Yay!
Clearing blocking flag since this is for the add-on.
blocking2.0: beta8+ → ---
Target Milestone: --- → 1.6
Attached patch Strength UI, v1 (obsolete) — Splinter Review
First stab at stripping out strength UI and tracking of "is this a custom key?".

This is a branch from Bug 603489's work.
16:43:26 <philiKON> the patch in Bug 597427 is now mostly obsolete because i'm revamping that code for jpake right now

Also adding a link to 'parent' bug.
See Also: → 612699
(In reply to comment #3)
> 16:43:26 <philiKON> the patch in Bug 597427 is now mostly obsolete because i'm
> revamping that code for jpake right now

Bug 597427 is about the integrated Firefox UI, though, not the add-on UI (which is what this bug is about). So this and bug 597427 are quite unrelated.
> Bug 597427 is about the integrated Firefox UI, though, not the add-on UI (which
> is what this bug is about). So this and bug 597427 are quite unrelated.

Aaaah, I thought you were commenting on *my* patch, which is in this bug (Bug 613617). You're talking about your patch on Bug 597427, which I reviewed. 

Reading comprehension fail, sorry. Good to see this work still good, though :D
Attached patch v2 (obsolete) — Splinter Review
Rips out everything we don't need (strength meter, custom Sync Key, etc.). Hyphenates Sync Keys as you type (only needed when logging into an existing account and when your Sync Key was changed on another computer)
Assignee: nobody → philipp
Attachment #491992 - Attachment is obsolete: true
Attachment #493067 - Flags: review?(mconnor)
Comment on attachment 493067 [details] [diff] [review]
v2

>diff --git a/ui/firefox/locale/prefs.dtd b/ui/firefox/locale/prefs.dtd

> <!ENTITY syncKeyHelp.label         "What does the strength mean?">

Shouldn't this entity go as well?
Attachment #493067 - Flags: review?(mconnor) → review+
(In reply to comment #7)
> > <!ENTITY syncKeyHelp.label         "What does the strength mean?">
> 
> Shouldn't this entity go as well?

Yes! Good catch.
Attached patch v3Splinter Review
Remove string + helper method for Sync Key help link as well.
Attachment #493067 - Attachment is obsolete: true
https://hg.mozilla.org/services/fx-sync/rev/3641b7ea2565
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
verified with 1.6b1
Status: RESOLVED → VERIFIED
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.