Closed
Bug 613617
Opened 14 years ago
Closed 14 years ago
Addon UI: Update to simplify crypto
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
1.6
People
(Reporter: philikon, Assigned: philikon)
References
Details
Attachments
(1 file, 2 obsolete files)
23.32 KB,
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #612699 +++ This entails: * Surface a notification for existing Sync users that a new Sync Key has been generated from their old Sync Key/passphrase. They don't need to do anything on their other machines, but their old Sync Key/passphrase is no longer valid. * The account creation wizard won't allow you to set a custom passphrase, it just shows a generated one. * The My Sync Key dialog no longer allows you to set a custom passphrase, it just allows you to generate a new one. * Everywhere Sync Keys are shown and entered we need to aid the user with hyphens. The hyphenation/dehyphenation should happen in Weave.Util.* helpers, the UI code shouldn't have to know about specific Sync Key formats. * Since we're ripping out custom passphrases we can also rip out the whole Sync Key strength meter thingie. Yay!
Assignee | ||
Comment 1•14 years ago
|
||
Clearing blocking flag since this is for the add-on.
blocking2.0: beta8+ → ---
Target Milestone: --- → 1.6
Comment 2•14 years ago
|
||
First stab at stripping out strength UI and tracking of "is this a custom key?". This is a branch from Bug 603489's work.
Comment 3•14 years ago
|
||
16:43:26 <philiKON> the patch in Bug 597427 is now mostly obsolete because i'm revamping that code for jpake right now Also adding a link to 'parent' bug.
See Also: → 612699
Assignee | ||
Comment 4•14 years ago
|
||
(In reply to comment #3) > 16:43:26 <philiKON> the patch in Bug 597427 is now mostly obsolete because i'm > revamping that code for jpake right now Bug 597427 is about the integrated Firefox UI, though, not the add-on UI (which is what this bug is about). So this and bug 597427 are quite unrelated.
Comment 5•14 years ago
|
||
> Bug 597427 is about the integrated Firefox UI, though, not the add-on UI (which > is what this bug is about). So this and bug 597427 are quite unrelated. Aaaah, I thought you were commenting on *my* patch, which is in this bug (Bug 613617). You're talking about your patch on Bug 597427, which I reviewed. Reading comprehension fail, sorry. Good to see this work still good, though :D
Assignee | ||
Comment 6•14 years ago
|
||
Rips out everything we don't need (strength meter, custom Sync Key, etc.). Hyphenates Sync Keys as you type (only needed when logging into an existing account and when your Sync Key was changed on another computer)
Assignee: nobody → philipp
Attachment #491992 -
Attachment is obsolete: true
Attachment #493067 -
Flags: review?(mconnor)
Comment 7•14 years ago
|
||
Comment on attachment 493067 [details] [diff] [review] v2 >diff --git a/ui/firefox/locale/prefs.dtd b/ui/firefox/locale/prefs.dtd > <!ENTITY syncKeyHelp.label "What does the strength mean?"> Shouldn't this entity go as well?
Attachment #493067 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 8•14 years ago
|
||
(In reply to comment #7) > > <!ENTITY syncKeyHelp.label "What does the strength mean?"> > > Shouldn't this entity go as well? Yes! Good catch.
Assignee | ||
Comment 9•14 years ago
|
||
Remove string + helper method for Sync Key help link as well.
Attachment #493067 -
Attachment is obsolete: true
Assignee | ||
Comment 10•14 years ago
|
||
https://hg.mozilla.org/services/fx-sync/rev/3641b7ea2565
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•