613668 - shouldn't create release repack ftppollers unless we need them

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

Currently, we only need them when we're doing partner repacks.

Comment 1

[Syed Albiz [:salbiz]]

Attachment: only create locale poller as needed

will require a bit of testing to ensure that it doesn't break in the case of multiple branch release builders across masters.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 492011 [details] [diff] [review]
only create locale poller as needed

Hmmmm. While you're here can you make the platforms that go to unsigned configurable? Defaulting to ('win32',) is fine, but I think we should be able to override in the release config by specifying signedPlatforms. We'll need this when mac signing lands.

Looks fine otherwise.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 492011 [details] [diff] [review]
only create locale poller as needed

Damn...I keep adjusting the wrong flag. Fixing feedback? request.

Comment 4

[Chris AtLee [:catlee]]

Comment on attachment 492011 [details] [diff] [review]
only create locale poller as needed

Looks good.

Will this change where we would send out notifications to release-drivers?

Comment 5

[Syed Albiz [:salbiz]]

Attachment: make signedPlatforms a branch-configurable option

Done, moving that tuple of platforms into buildbot-configs now. Tested on staging by starting up buildbot and verifying that only branches with doPartners = True set had pollers created for the right places by looking for twistd.log entries

Comment 6

[Syed Albiz [:salbiz]]

Attachment: add signedPlatform releaseConfig element

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 493012 [details] [diff] [review]
add signedPlatform releaseConfig element

Can you set ('win32',) as the default in release.py so we can avoid adding another thing to all of the configs?

Comment 8

[Syed Albiz [:salbiz]]

Attachment: default to just win32 if signedPlatforms not specified in releaseConfig

Tested same way as before, correct pollers created in output of twistd.log

Comment 9

[[e-mail] (:bhearsum)]

Comment on attachment 493133 [details] [diff] [review]
default to just win32 if signedPlatforms not specified in releaseConfig

r=me if you move the signedPlatforms assignment up to the top of generateReleaseBranchObjects -- I suspect we'll be wanting it elsewhere down the road.

Comment 10

[Syed Albiz [:salbiz]]

Attachment: move signedPlatforms stanza up top

Done

Comment 11

[[e-mail] (:bhearsum)]

Planning to do a reconfig with this tomorrow morning.

Comment 12

[[e-mail] (:bhearsum)]

Comment on attachment 493299 [details] [diff] [review]
move signedPlatforms stanza up top

changeset:   1235:f0b73ac466b9

Comment 13

[[e-mail] (:bhearsum)]

Masters have been updated.

Comment 14

[[e-mail] (:bhearsum)]

All done here now, I think.