613678 - Make getpersonas.com pass W3C test

Status: RESOLVED FIXED

(Websites Graveyard :: getpersonas.com, defect)

Description

[Tobias (:Tobbi) Markus]

Currently, the GetPersonas website doesn't pass for a couple of reasons:
* '&' is not being escaped as &
* Unknown attribute 'persona' on element div.
* Some required attribute missing on script tag.

Validation report:
http://www.getpersonas.com/en-US/

Comment 1

[Matthew N. [:MattN]]

Attachment: v.1 html encode name, fix tag nesting & remove @charset for inline script

* html encode persona name
* fix some tag nesting
* remove @charset for inline scripts since it is only valid for external scripts

Not fixed:
the "unknown" 'persona' attribute is what holds the information about a persona so that the Personas browser extension can preview and install it.  Changing how this works is non-trivial.  The lightweight themes implementation in Firefox 3.6+ uses the 'data-browsertheme' attribute which is valid.

Comment 2

[Toby Elliott [:telliott]]

Comment on attachment 501250 [details] [diff] [review]
v.1 html encode name, fix tag nesting & remove @charset for inline script

Changes look good

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 501250 [details] [diff] [review]
v.1 html encode name, fix tag nesting & remove @charset for inline script

Deb tells me that Fred should review patches for getpersonas.com

Comment 4

[Fred Wenzel [:wenzel]]

Comment on attachment 501250 [details] [diff] [review]
v.1 html encode name, fix tag nesting & remove @charset for inline script

These look good.

Comment 5

[Matthew N. [:MattN]]

(In reply to comment #4)
> These look good.

Thanks for the quick reviews.

Checked-in as r80223

Steps to verify:
Run the W3C validator on the following pages and make sure there are no validation errors other than having the unknown 'persona' attribute.  This attribute is important to how personas work and cannot be changed easily.

* http://www.getpersonas.com/en-US/
* http://www.getpersonas.com/en-US/gallery/